Failing to get comment with some zips about libzip HOT 8 CLOSED

This is not a bug in libzip.
The archive comment for this archive is 1455 bytes. After the "signed by SignApk" part is a zero byte and then the other 1400+ bytes follow. If you just print them with printf, you won't see anything after the zero byte, but it's there.

from libzip.

Hmm, somehow I don't get the zero byte, and even

printf("%s\n", zip_get_archive_comment(archive, nullptr, ZIP_FL_ENC_GUESS));

does show the very same string I pasted in my first comment. Could it be a problem with my locale?

from libzip.

printf stops writing when it encounters a zero byte (strings in C are zero-terminated).
You should pass a pointer to a variable instead of nullptr and look at the returned length to find out how big the comment is.

from libzip.

My point is I don't get the zero byte after the "signed by SignApk" sequence. The lenp argument says the comment is 2931 bytes long.

from libzip.

So what does (untested, something like):

char *foo=zip_get_archive_comment(archive, nullptr, ZIP_FL_ENC_GUESS)
printf("%x\n", foo[strlen("signed by SignApk")]);

print?

from libzip.

That snippet prints ffffffe2.

I should probably mention that I'm using this code from a C++ program, not sure if related. I'll try again with a minimal test program in C.

from libzip.

I'm sorry, you're right. I misunderstood.
There was a bug in libzip. CP437 '0' was not translated to UTF-8 '0'.
I've just pushed a commit that should fix this, please let me know if it fixes the problem for you.

from libzip.

Yes, the fix works for me. Thanks!

from libzip.