Comments (5)
Do you have a pointer to documentation about using subprojects with CMake and best practices for variables in that case?
This change is quite invasive since all packagers and users setting options will need to update their variables, and we can't add backward compatibility since this would defeat the point of the change.
(At least BUILD_SHARED_LIBS
should consider the project-wide setting without a LIBZIP_
prefix.)
from libzip.
Do you have a pointer to documentation about using subprojects with CMake and best practices for variables in that case? This change is quite invasive since all packagers and users setting options will need to update their variables, and we can't add backward compatibility since this would defeat the point of the change. (At least
BUILD_SHARED_LIBS
should consider the project-wide setting without aLIBZIP_
prefix.)
https://discourse.cmake.org/t/best-practices-for-option-naming/2039 for an example, a lot of libraries do that. And yeah you are right about BUILD_SHARED_LIBS
, it actually affects add_library behavior so it should be kept as is (I reverted that in the PR). The issue with needing to change the options when packaging is indeed kind of annoying one, I am not really sure what would be the best solution for that.
from libzip.
We've come up with an idea how to support this without breaking backwards compatibility:
We add a new option LIBZIP_AS_SUBPROJECT
. If that option is set to ON
, then all option names are prefixed with LIBZIP_
, otherwise the old names are used.
CMake supports that quite easily:
include(CMakeDependentOption)
option(LIBZIP_AS_SUBPROJECT "Prefix option names with LIBZIP_" OFF)
cmake_dependent_option(RUN_REGRESS "Run regression tests" ON "NOT LIBZIP_AS_SUBPROJECT" ON)
cmake_dependent_option(LIBZIP_RUN_REGRESS "Run regression tests" ON "LIBZIP_AS_SUBPROJECT" ${RUN_REGRESS})
Could you please update your PR to duplicate all options as described above?
from libzip.
We've come up with an idea how to support this without breaking backwards compatibility:
We add a new option
LIBZIP_AS_SUBPROJECT
. If that option is set toON
, then all option names are prefixed withLIBZIP_
, otherwise the old names are used.CMake supports that quite easily:
include(CMakeDependentOption) option(LIBZIP_AS_SUBPROJECT "Prefix option names with LIBZIP_" OFF) cmake_dependent_option(RUN_REGRESS "Run regression tests" ON "NOT LIBZIP_AS_SUBPROJECT" ON) cmake_dependent_option(LIBZIP_RUN_REGRESS "Run regression tests" ON "LIBZIP_AS_SUBPROJECT" ${RUN_REGRESS})Could you please update your PR to duplicate all options as described above?
Hi, sorry that it took me so long to respond, I had other things to do and didn't remember this. It looks like doing it like that forcefully sets RUN_REGRESS to ON (or OFF if specified as the last argument to cmake_dependent_option) if LIBZIP_AS_SUBPROJECT is specified instead of not modifying it at all so that's not ideal.
from libzip.
I don't see it, but since this was only a proposal, you could fix this in your pull request :-)
from libzip.
Related Issues (20)
- ZIP_CM_SHRINK and ZIP_CM_IMPLODE give unsupported compression method error HOT 1
- Error when use with CPM (cmake package manager) HOT 1
- ZIP_ER_INCONS error (Zip archive inconsistent) on an apparently valid ZIP archive HOT 2
- error while loading shared libraries from /usr/local/lib, dir not in path under Linux Mint HOT 1
- 4 GB limit? HOT 1
- Functionality for creation of split-volume zip files based on individual byte ranges of complete file HOT 3
- Creating ZIP archives is not properly handling wchar_t on Windows 11/x64. HOT 1
- Crash with illegal instruction under Windows 11 x64 ARM virtualization HOT 2
- Fix documentation of `zip_source_win32handle` HOT 1
- Enhance documentation of `zip_source_zip_file` and `zip_source_zip` HOT 3
- writing zip file fails HOT 2
- Using the libzip library to package files suddenly increases CPU load HOT 5
- Improve API Documentation HOT 5
- Compilation error w/ MSYS2 GCC: Incompatible pointer types HOT 5
- CMake FetchContent support HOT 2
- New release? HOT 2
- zip_open fails with a file on the filesystem with data deduplication turned on (Windows)
- `zip_source_filep_create` fails on Windows with a large zip archive
- `zip_fread()` returns -1 in case of error, how to get more information ? HOT 1
- [1.11] LIBZIP_VERSION_MICRO empty breaks build
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libzip.