The create-meme-scraper from nigorita

Memes folder name

The memes folder name should be memes, not Pix.

Not a huge deal, but:

small details like this can be important in projects
uppercase letters in file and folder names can cause problems (especially cross platform - between Linux and Windows, for example)

Unused Variables / Variables Declared with Var

Some variables can be declared with const instead of var:

Lines 17 to 19 in dff4dd2

    
           var fs = require("fs"); 
        
           var https = require("https"); 
        
           var decode = require("decode-html");

create-meme-scraper/index.js

Lines 24 to 26 in dff4dd2

    
           var fullUrl = url; 
        
           var file = fs.createWriteStream(localPath); 
        
           var request = https.get(url, function(response) {

Using const instead will prevent some unusual bugs and prevent the variables from being accidentally reassigned.

Also, some of those variables are unused (not used anywhere else), so probably don't even need to be assigned:

You can see the unused variables because their colors are not as bright as the other ones.

💥 Doesn't get the first 10 images

When the program is run, it doesn't download the first 10 images - it downloads image 88 to 95.

Variable Naming / Reuse

The naming of some of the variables could be improved to better communicate to others what they actually are - eg. body1, body2, itm:

create-meme-scraper/index.js

Line 36 in dff4dd2

const body1 = body.match(/ src.+watermark=none/g);

create-meme-scraper/index.js

Line 40 in dff4dd2

const body2 = body1.map(itm => {

Another "best practices" thing is to not reuse / reassign the value of parameters (not a huge deal, but some teams may not allow this):

create-meme-scraper/index.js

Lines 41 to 46 in dff4dd2

    
           itm = itm.match(/\/.+watermark=none/); 
        
           itm = "https://memegen.link" + itm; 
        
           // itm = decode(itm); 
        
           itm = itm.replace("&#39;", "'"); 
        
           itm = itm.replace("&#39;", "'"); 
        
           itm = itm.replace("’", "'");

Nice use of a function!

Nice use of a function to separate out some of the code:

create-meme-scraper/index.js

Lines 23 to 29 in dff4dd2

    
           function saveImageToDisk(url, localPath) { 
        
             var fullUrl = url; 
        
             var file = fs.createWriteStream(localPath); 
        
             var request = https.get(url, function(response) { 
        
               response.pipe(file); 
        
             }); 
        
           }

Fails when Pix folder doesn't exist

If I delete the Pix folder to see if the program gets new images, it fails with an error:

Images saved to Git / GitHub

Using your .gitignore file you can ignore the images folder so that it doesn't show up on GitHub.

In order to do this, you can try googling "gitignore folder".

Otherwise they will be on GitHub and will be downloaded when people download your program:

To ignore the things that are downloaded by the program is often considered best practice.

Extra debugging output / show progress in output

When the program is run, extra output appears in the terminal (see screenshots below). It would be nice to have the output free of this extra debugging information.

On the other side of things, it would also be good to have a progress indicator for the download of each image. This could be shown as either a message before and/or after each image or even better, a progress meter.

Extraneous Vim swap file

There's an extra .swp file from Vim in the project root, probably want to remove that:

https://github.com/nigorita/create-meme-scraper/blob/dff4dd228ae10bda5e2d061f9af0e2d804bb2f41/.swp

nigorita / create-meme-scraper Goto Github PK

create-meme-scraper's People

Contributors

Watchers

create-meme-scraper's Issues

Memes folder name

Unused Variables / Variables Declared with Var

💥 Doesn't get the first 10 images

Variable Naming / Reuse

Nice use of a function!

Fails when Pix folder doesn't exist

Images saved to Git / GitHub

Extra debugging output / show progress in output

Extraneous Vim swap file

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	var fs = require("fs");
	var https = require("https");
	var decode = require("decode-html");

	var fullUrl = url;
	var file = fs.createWriteStream(localPath);
	var request = https.get(url, function(response) {

	itm = itm.match(/\/.+watermark=none/);
	itm = "https://memegen.link" + itm;
	// itm = decode(itm);
	itm = itm.replace("'", "'");
	itm = itm.replace("'", "'");
	itm = itm.replace("’", "'");

	function saveImageToDisk(url, localPath) {
	var fullUrl = url;
	var file = fs.createWriteStream(localPath);
	var request = https.get(url, function(response) {
	response.pipe(file);
	});
	}