Code Monkey home page Code Monkey logo

minecraft-control's People

Stargazers

 avatar  avatar

Watchers

 avatar  avatar  avatar

Forkers

ryush00

minecraft-control's Issues

Comments on your code

Hello,

I got the same idea to create a similar project in Node.js when I found a couple of Node.js projects.
Yours was the most recent one so I looked into yours more in depth.

I still haven't tested your code yet.

After reading your code the only comments so far are the following:

Turn this:

var commandArgs = []
    .concat([
        "-jar",
        path.resolve(process.cwd(), self.options.server)
    ])
    .concat(self.options.javaOpts)
    .concat(self.options.extraOpts);

Into this:

var commandArgs = [
    [
        "-jar",
        path.resolve(process.cwd(), self.options.server)
    ],
    self.options.javaOpts,
    self.options.extraOpts];

Regards,
Emil Hemdal

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.