A library to use and verify the CODEOWNERS and .gitignore files
License: Apache License 2.0
I'm Niels Basjes.
I work as an IT-Architect/Inventor at https://www.bol.com where I design new systems that are usually special on some way when it comes to handling data.
I'm also an avid opensource contributor and you'll find patches of me in lots of Apache "BigData" projects. Committer for Apache Flink and Comitter/PMC for Apache Avro.
![renovate[bot] avatar](https://avatars.githubusercontent.com/in/2740?v=4 "renovate[bot]")
This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.
This repository currently has no open or pending branches.
.github/workflows/build.yml
actions/checkout v4.1.6@a5ac7e51b41094c92402da3b24376905380afc29actions/cache v4.0.2@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9actions/setup-java v4.2.1@99b8673ff64fbf99d8d325f52d9a5bdedb8483e9codecov/codecov-action v4.4.1@125fc84a9a348dbcf27191600683ec096ec9021c
codeowners-reader/pom.xml
org.apache.maven.plugins:maven-toolchains-plugin 3.2.0org.eclipse.sisu:sisu-maven-plugin 0.9.0.M2org.apache.maven.plugins:maven-shade-plugin 3.6.0enforcer/pom.xml
javax.inject:javax.inject 1org.apache.maven.plugins:maven-shade-plugin 3.6.0org.eclipse.sisu:sisu-maven-plugin 0.9.0.M2enforcer/src/it/covered/pom.xml
enforcer/src/it/gitignore/pom.xml
enforcer/src/it/missing/pom.xml
gitignore-reader/pom.xml
org.apache.maven.plugins:maven-toolchains-plugin 3.2.0org.eclipse.sisu:sisu-maven-plugin 0.9.0.M2pom.xml
org.antlr:antlr4-maven-plugin 4.13.1org.apache.maven.plugins:maven-surefire-plugin 3.2.5org.apache.maven.enforcer:enforcer-api 3.5.0org.apache.maven:maven-core 3.9.7org.apache.maven.plugins:maven-toolchains-plugin 3.2.0org.apache.maven.plugins:maven-invoker-plugin 3.7.0org.apache.maven.plugins:maven-surefire-plugin 3.2.5org.junit:junit-bom 5.10.2commons-io:commons-io 2.16.1org.slf4j:slf4j-api 1.7.36org.slf4j:slf4j-simple 1.7.36org.apache.maven.plugins:maven-artifact-plugin 3.5.1org.apache.maven.plugins:maven-artifact-plugin 3.5.1org.apache.maven.plugins:maven-gpg-plugin 3.2.4org.apache.maven.plugins:maven-javadoc-plugin 3.7.0org.apache.maven.plugins:maven-deploy-plugin 3.1.2io.github.git-commit-id:git-commit-id-maven-plugin 8.0.2org.apache.maven.plugins:maven-resources-plugin 3.3.1org.apache.maven.plugins:maven-jar-plugin 3.4.1org.apache.maven.plugins:maven-surefire-plugin 3.2.5org.apache.maven.plugins:maven-toolchains-plugin 3.2.0org.apache.maven.plugins:maven-source-plugin 3.3.1org.apache.maven.plugins:maven-clean-plugin 3.3.2org.apache.maven.plugins:maven-enforcer-plugin 3.5.0org.codehaus.mojo:extra-enforcer-rules 1.8.0org.apache.maven.plugins:maven-compiler-plugin 3.13.0io.github.git-commit-id:git-commit-id-maven-plugin 8.0.2org.apache.rat:apache-rat-plugin 0.16.1org.jacoco:jacoco-maven-plugin 0.8.12org.apache.maven.plugins:maven-release-plugin 3.0.1nl.basjes.maven.release:conventional-commits-version-policy 1.0.6org.cyclonedx:cyclonedx-maven-plugin 2.8.0
.mvn/wrapper/maven-wrapper.properties
maven 3.9.7
The library cannot parse the example file provided by GitLab.
It fails with the following error
Unsupported escape character: \#
This seems to be the problem:
# Files with a `#` can still be accessed by escaping the pound sign:
\#file_with_pound.rb @owner-file-with-pound
I know it is explicitly NOT supported by GitHub or Bitbucket, but GitLab officially supports this quirk.
We are operating a historically grown monorepo where some of the modules are of shared nature. Thus, some modules contain multiple approvers in a CODEOWNERS entry. Nevertheless, the first in the list is still somewhat considered the "main" owner. (As irritating as that might sound.)
[SomeSection]
/module-a/ @foo @bar
/module-b/ @foo @baz
For both of these path specifications @foo is not the first item in the list retrieved with ::getAllApprovers.
The CodeOwners implementation does some sorted() calls on the approver streams. I think the "challenging" location is in ::visitApprovalRule.
Would it be feasible to introduce some unsortedApprovers property which could be a tunable like verbose? Then the sorted() calls could take a Comparator which behaves according to the unsortedApprovers property either always returning 0 or perform the string-natural sort as is the default with sorted().
PS: Thanks for this library!
If I have a file named foo*txt (mkdir foo\*txt) and file foo.txt
by adding the rule foo\*txt to gitignore, I should be able to ignore one but not the other.
Current implementation will not detect a hit on foo*txt file
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
Django
The Web framework for perfectionists with deadlines.
Laravel
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft
Open source projects and samples from Microsoft.
Google
Google ❤️ Open Source for everyone.
Alibaba
Alibaba Open Source for everyone
D3
Data-Driven Documents codes.
Tencent
China tencent open source team.