Use selection for "Add braces to if statement" about abracadabra HOT 2 CLOSED

That's a nice suggestion, thank you @canadaduane 👍

from abracadabra.

Hey @canadaduane!

So, I give this deeper thoughts and while it seems interesting when you're in the spirit of wrapping statements inside an if, it causes problems that I want to keep out of this extension scope.

In short, that's not a "refactoring".

if (condition === 'true') 
let ok
ok = someFunc()
callAnotherFunc(ok)

and

if (condition === 'true') {
  let ok
  ok = someFunc()
  callAnotherFunc(ok)
}

are not the same thing. My goal for Abracadabra is to propose automated refactorings that you can use safely. If we fail to do so, I'd consider this a bug that should be fixed.

I can definitely see that if I select multiple lines, I explicitly want to wrap them inside the leading if statement. But when I do so, I'm effectively changing what the code does and would expect existing passing tests to fail (or failing tests to pass).

Therefore, I think that should be implemented in a different extension that would have a different goal. I created hocus-pocus for similar reasons, but it focuses on creating code that doesn't exist, based on the intention to create it. I feel what we're talking about is yet another kind of operation to make developer life more convenient. But I don't have one in mind at the moment.

Any way, thanks for suggesting. I think the idea is interesting for the developer. But I don't think it should be in Abracadabra.

from abracadabra.