Extract Variable insert position doesn't right about abracadabra HOT 2 CLOSED

Indeed, there is an issue when computing the position for the extraction. It's probably looking for the highest possible scope (I don't recall the details) and doesn't consider the position of the references it has.

We probably can refine this so it's created just before the highest reference, like illustrated in your expect.

Thanks for reporting @tjx666, always appreciated!

from abracadabra.

That was a specific one. Hopefully, your test was really helpful to repro. It was a combination of:

• Replacing multiple occurrences
• Extracting an expression that refers to a variable
• Having the variable declared in the common ancestor of all extracted occurrences

By default, we were declaring the new variable at the top of that ancestor, resulting in the reported bug.

I fixed that so if there is a variable referenced that is declared in the scope, we make sure to declare the extracted variable after.

I captured that with a test and it's passing now 👍

Thank you @tjx666 for the detailed report. That was really, really helpful ❤️

from abracadabra.