nico-curti / rfbp Goto Github PK
View Code? Open in Web Editor NEWReplicated Focusing Belief Propagation algorithm
Home Page: https://nico-curti.github.io/rFBP
License: Other
Replicated Focusing Belief Propagation algorithm
Home Page: https://nico-curti.github.io/rFBP
License: Other
Hi! This issue is related to the JOSS review (openjournals/joss-reviews#2663).
I tried to install the Python package from pip in a fresh venv and noticed that the requirements aren't installed as they should be.
~ pipenv install ReplicatedFocusingBeliefPropagation
Installing ReplicatedFocusingBeliefPropagation…
Error: An error occurred while installing ReplicatedFocusingBeliefPropagation!
Error text: Collecting replicatedfocusingbeliefpropagation
Downloading ReplicatedFocusingBeliefPropagation-1.0.1.tar.gz (417 kB)
ERROR: Command errored out with exit status 1:
command: /Users/lenzda/.local/share/virtualenvs/py-Ob9eXrK4/bin/python3.7m -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/var/folders/4x/6yrptfcn4kxdynxfy3qv1g20lmvv2v/T/pip-install-uu4qb3_7/replicatedfocusingbeliefpropagation/setup.py'"'"'; __file__='"'"'/private/var/folders/4x/6yrptfcn4kxdynxfy3qv1g20lmvv2v/T/pip-install-uu4qb3_7/replicatedfocusingbeliefpropagation/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /private/var/folders/4x/6yrptfcn4kxdynxfy3qv1g20lmvv2v/T/pip-pip-egg-info-vplpgjcz
cwd: /private/var/folders/4x/6yrptfcn4kxdynxfy3qv1g20lmvv2v/T/pip-install-uu4qb3_7/replicatedfocusingbeliefpropagation/
Complete output (5 lines):
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/private/var/folders/4x/6yrptfcn4kxdynxfy3qv1g20lmvv2v/T/pip-install-uu4qb3_7/replicatedfocusingbeliefpropagation/setup.py", line 8, in <module>
import numpy as np
ModuleNotFoundError: No module named 'numpy'
----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
This is likely caused by a bug in ReplicatedFocusingBeliefPropagation. Report this to its maintainers.
✘ Installation Failed
I checked your travis config and noticed that you had to implement some workarounds because of a setuptools issue (pypa/setuptools#2352). Could you use this to patch the pip install accordingly?
Hi,
during my review for JOSS (openjournals/joss-reviews#2663) I looked for what they call "functionality documentation". I was not able to find any API-Documentation on your GitHub page. Could you maybe add this?
Hi! This issue is related to the JOSS review (openjournals/joss-reviews#2663).
I noted that towards the end of the README
, you refer to the CONTRIBUTING.md
for instructions on how to contribute to this project, but this file doesn't exist.
The same is true for the issue template and for the PR template.
During my review for JOSS (openjournals/joss-reviews#2663), I also found that for your C++ Code there are not always docstrings for functions. Could you maybe add these and while on it make sure they can be parsed from oxygen or whatever?
Also your Python Docstrings could be cleaned up a bit to be a bit more consistent regarding the parameter types. If you revisit them, make sure they follow the sphinx format (or some other but sphinx is really easy to use). If you want to, you could also remove the parameter types and replace them by Python's type annotations.
This is basically a preparation for #4
Hi,
first I want to thank you for this incredible work.
While reviewing for JOSS (openjournals/joss-reviews#2663), I noted that your license file is markdown and not a plain text file as required :)
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.