nickmonad / fabrik Goto Github PK

Need a mechanism to do real CI - master should be merged into the development branch in order to ensure there are no merge conflicts and that no unit test regressions have been introduced. This will also require some database/cache work to correlate github status updates back to the latest PR commit, not the new commit formed by merging master.

Environment names in the parameter.json should be development, staging, and production to match conventional language, instead of development, master, and release

Will require some changes to the lambda functions and will break all builds until they upgrade to the new names.

S3 storages adds up pretty quickly and build artifacts are created for each step of the pipeline across all branches

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-s3-bucket-lifecycleconfig-rule.html

As far as I know, there is no way to set the log group and retention length via cloudformation on a codebuild project. Currently, we have a bunch of cruft just hanging out in the cloudwatch logs. Instead, there should be a periodic lambda function to check for all codebuild logs that are older than a couple weeks or so and remove them

Lambda functions that live in the lib/* folder should be optional and completely configurable by the user. This includes functions that involve deploying to S3, notifying a slack channel when cloudwatch logs match a regex, or other, non-core functions users will use to augment their infrastructure.