Code Monkey home page Code Monkey logo

Comments (7)

mdfirman avatar mdfirman commented on May 28, 2024

Thanks for your interest.

The benefit of doing it is as written in the comment there – we disable the gradients to save memory.

In practice you can enable gradient if you like. We found that it made little difference to scores.

from manydepth.

WBS-123 avatar WBS-123 commented on May 28, 2024

Thanks for reply!I'll have a try

from manydepth.

WBS-123 avatar WBS-123 commented on May 28, 2024

Thanks for your interest.

The benefit of doing it is as written in the comment there – we disable the gradients to save memory.

In practice you can enable gradient if you like. We found that it made little difference to scores.

I try to enable gradients of on lookup images, and modifiy the code like this:
in line 276, remove

with torch.no_grad():

in line 290~291, remove detach(), like this:

confidence_mask = self.compute_confidence_mask(cost_volume *(1 - missing_mask))

is this correct?
and if I enable gradients of on lookup images, the result will get worse? Should I change the the hyper-parameters such as num_epoch/lr ?

from manydepth.

mdfirman avatar mdfirman commented on May 28, 2024

Yes it looks like those changes should be enough to get gradients to flow to the lookup images.

But I don't know if the result would get better or worse if you do this. You will have to try it out and see!

from manydepth.

WBS-123 avatar WBS-123 commented on May 28, 2024

Yes it looks like those changes should be enough to get gradients to flow to the lookup images.

But I don't know if the result would get better or worse if you do this. You will have to try it out and see!

Thx! If I have any result, I will post here

from manydepth.

WBS-123 avatar WBS-123 commented on May 28, 2024

After modified the code as above, I got this result:
2021-06-17 15-16-34 的屏幕截图
it seems like a little worse than origin result.
I'm not sure if it's due to randomness.
Overall, I think the two methods made little difference to score.

from manydepth.

mdfirman avatar mdfirman commented on May 28, 2024

Thanks a lot for reporting back. Glad you could confirm our suspicions.

from manydepth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.