Code Monkey home page Code Monkey logo

Comments (4)

joaqcid avatar joaqcid commented on June 12, 2024 1

@svishnevsky try updating to 1.0.5 should work fine

from actions-executing.

joaqcid avatar joaqcid commented on June 12, 2024

ok, ill take a look, i think its probably due to need to recompile actions-executing with latest ngxs

from actions-executing.

svishnevsky avatar svishnevsky commented on June 12, 2024

Hi @joaqcid ,

Looks like it was built with "ng-package.json" instead of "ng-package.prod.json" and "@ngxs/store" was compiled as umd package. Will you able to double check the build process?

Content of the compiled file actions-executing.module.d.ts is:

import { ModuleWithProviders } from '@angular/core';
import * as i0 from "@angular/core";
import * as i1 from "@ngxs/store";
export declare class NgxsActionsExecutingModule {
    static forRoot(): ModuleWithProviders<NgxsActionsExecutingModule>;
    static ɵfac: i0.ɵɵFactoryDeclaration<NgxsActionsExecutingModule, never>;
    static ɵmod: i0.ɵɵNgModuleDeclaration<NgxsActionsExecutingModule, never, [typeof i1.ɵz], never>;
    static ɵinj: i0.ɵɵInjectorDeclaration<NgxsActionsExecutingModule>;
}

But it should be:

import { ModuleWithProviders } from '@angular/core';
import * as i0 from "@angular/core";
import * as i1 from "@ngxs/store";
export declare class NgxsActionsExecutingModule {
    static forRoot(): ModuleWithProviders<NgxsActionsExecutingModule>;
    static ɵfac: i0.ɵɵFactoryDeclaration<NgxsActionsExecutingModule, never>;
    static ɵmod: i0.ɵɵNgModuleDeclaration<NgxsActionsExecutingModule, never, [typeof i1.ɵNgxsFeatureModule], never>;
    static ɵinj: i0.ɵɵInjectorDeclaration<NgxsActionsExecutingModule>;
}

The difference is on line 7 [typeof i1.ɵz] -> [typeof i1.ɵNgxsFeatureModule].

The code itself look good, I've cloned it, run npm i && npm run build and the output is correct.

from actions-executing.

jeanpylone-dh avatar jeanpylone-dh commented on June 12, 2024

Perfect on my end!

Thank you 👍

from actions-executing.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.