nguyen703 / vnlunar Goto Github PK

Problem:

1. User must split parameters to correctly convert solar to lunar. Why do you use the DateTime type?
2. Output does not demonstrate. Always remember what index describes day or month.

Suggestion:

1. You can use DateTime or an object instead of splitting parameters.
2. You can define LunarDateTime class to describe lunar DateTime instead of an array.

final DateTime inputDate = ... // 

/// class LunarDateTime {
///  public day; 
///  public month;
///  public year;
/// ... everything in here
/// }
final LunarDateTime lunarDateTime =  convertSolar2Lunar(inputDate);

// revert lunar -> solar
final DateTime solarDateTime = convertLunar2Solar(lunarDateTime);