Code Monkey home page Code Monkey logo

Comments (6)

nfarina avatar nfarina commented on August 16, 2024

Thanks for the kudos :) Glad you're finding the class useful!

So I definitely considered separating the FrameAdditions class out into its own file, and I think it's more natural that way especially if you want to use these category methods yourself outside the callout view implementation.

However I believe the class is easier for folks to consume as a single .h/.m pair and I think it's worth it to combine everything together for that reason alone.

You could certainly lift the @interface portion of FrameAdditions into a separate UIView+SMFrameAdditions.h on your own and that would work fine. It's not ideal though I admit.

from calloutview.

JRG-Developer avatar JRG-Developer commented on August 16, 2024

Thanks for the reply, Nick! I thought I'd just add my suggestion/feedback in the mix. You're right, though, users can certainly choose to fork the repository and make whatever changes they'd like, which works well enough for me.

I'm closing this issue as it sounds like it has already been thoroughly considered.

Thanks!
Joshua

from calloutview.

exalted avatar exalted commented on August 16, 2024

I won't argue if callout view class files are easier to import if SMFrameAdditions is embedded, that's fair enough; yet I believe UIView+SMFrameAdditions deserve to have its own repo for anything else. Please reopen this issue and create a separate repository just for sake of framing–math–gods and let us know when you're done.

RSVP

P.S.: I am tempted to create my own, but I don't mean to get any credits for that.

from calloutview.

nfarina avatar nfarina commented on August 16, 2024

Ha, well I didn't think it was worth a whole repo but I did make a Gist for it originally:

https://gist.github.com/3412730

from calloutview.

exalted avatar exalted commented on August 16, 2024

Can we add gist as a submodule in git? Weird?!

from calloutview.

nfarina avatar nfarina commented on August 16, 2024

I don't see why it wouldn't be possible—they're just repositories like anything else?

from calloutview.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.