Comments (6)
Thanks for the kudos :) Glad you're finding the class useful!
So I definitely considered separating the FrameAdditions class out into its own file, and I think it's more natural that way especially if you want to use these category methods yourself outside the callout view implementation.
However I believe the class is easier for folks to consume as a single .h/.m pair and I think it's worth it to combine everything together for that reason alone.
You could certainly lift the @interface
portion of FrameAdditions into a separate UIView+SMFrameAdditions.h
on your own and that would work fine. It's not ideal though I admit.
from calloutview.
Thanks for the reply, Nick! I thought I'd just add my suggestion/feedback in the mix. You're right, though, users can certainly choose to fork the repository and make whatever changes they'd like, which works well enough for me.
I'm closing this issue as it sounds like it has already been thoroughly considered.
Thanks!
Joshua
from calloutview.
I won't argue if callout view class files are easier to import if SMFrameAdditions is embedded, that's fair enough; yet I believe UIView+SMFrameAdditions deserve to have its own repo for anything else. Please reopen this issue and create a separate repository just for sake of framing–math–gods and let us know when you're done.
RSVP
P.S.: I am tempted to create my own, but I don't mean to get any credits for that.
from calloutview.
Ha, well I didn't think it was worth a whole repo but I did make a Gist for it originally:
https://gist.github.com/3412730
from calloutview.
Can we add gist as a submodule in git? Weird?!
from calloutview.
I don't see why it wouldn't be possible—they're just repositories like anything else?
from calloutview.
Related Issues (20)
- The current deployment target does not support automated __weak references HOT 2
- Xcode Warning when clear custom view set by another pin HOT 1
- Add support for tvOS MapKit 😊 added in 9.2 HOT 2
- animationDidStop delegate callback checks for finished HOT 3
- Crashing on CLLayer position contains NaN HOT 7
- Swift 3 support? HOT 1
- How to change the background HOT 1
- Content View Touch - weird behaviour HOT 2
- Crashing when annotation is selected programmatically in viewDidLoad
- Is it possible to increase the view height and allow a multiline subtitle? HOT 16
- Is it possible to add a touch event to the calloutview?
- convert to swift HOT 7
- Contentview with constraints fails HOT 1
- Using SMCalloutView wit Mapbox HOT 3
- Performance issues HOT 2
- Crash when tap near the screen edges HOT 3
- Increase Callout Popup delay HOT 5
- calloutView with AutoLayout
- Not issue but Question : Calloutview with Mapbox HOT 6
- Refresh callout view in calloutViewClicked HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from calloutview.