Code Monkey home page Code Monkey logo

Comments (5)

ivan-aksamentov avatar ivan-aksamentov commented on May 31, 2024 1

I mean the situation if you decide we don't use dataset saved in local storage, and when it's not passed as URL param, but input-fasta is passed. Then what dataset would you use?

Or you propose to not start unless both input-fasta and dataset-name is passed?

There are so many possible combinations that I am confused now.

from nextclade.

corneliusroemer avatar corneliusroemer commented on May 31, 2024

Per Ivan this works as intended. So what I'm suggesting is to change behavior to the following:

  • when someone passes URL params, don’t use state
  • only use state when people are not using URL params

from nextclade.

ivan-aksamentov avatar ivan-aksamentov commented on May 31, 2024

Note for myself: "not using state", selected dataset in this case, implies dataset autodetection at boot and then running with it. Not entirely straightforward with the current code organization. Need to move things around probabaly.

from nextclade.

corneliusroemer avatar corneliusroemer commented on May 31, 2024

Ah autodetect is a state that should be kept, states that shouldn't be used are all the ones that can be URL param configured, assume they are unset for a reason.

I'm not sure autodetect behavior is very crucial here one way or another.

from nextclade.

corneliusroemer avatar corneliusroemer commented on May 31, 2024

I mean the situation if you decide we don't use dataset saved in local storage, and when it's not passed as URL param, but input-fasta is passed. Then what dataset would you use?

Don't assume one, I'd say? Only use autorun when people specify a dataset to be safe. Yeah this might technically be breaking some people's links but I don't think many people use just input fasta and no specified dataset. We could check logs just in case :)

Or you propose to not start unless both input-fasta and dataset-name is passed?

Indeed!

from nextclade.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.