Comments (5)
I mean the situation if you decide we don't use dataset saved in local storage, and when it's not passed as URL param, but input-fasta
is passed. Then what dataset would you use?
Or you propose to not start unless both input-fasta
and dataset-name
is passed?
There are so many possible combinations that I am confused now.
from nextclade.
Per Ivan this works as intended. So what I'm suggesting is to change behavior to the following:
- when someone passes URL params, donβt use state
- only use state when people are not using URL params
from nextclade.
Note for myself: "not using state", selected dataset in this case, implies dataset autodetection at boot and then running with it. Not entirely straightforward with the current code organization. Need to move things around probabaly.
from nextclade.
Ah autodetect is a state that should be kept, states that shouldn't be used are all the ones that can be URL param configured, assume they are unset for a reason.
I'm not sure autodetect behavior is very crucial here one way or another.
from nextclade.
I mean the situation if you decide we don't use dataset saved in local storage, and when it's not passed as URL param, but input-fasta is passed. Then what dataset would you use?
Don't assume one, I'd say? Only use autorun when people specify a dataset to be safe. Yeah this might technically be breaking some people's links but I don't think many people use just input fasta and no specified dataset. We could check logs just in case :)
Or you propose to not start unless both input-fasta and dataset-name is passed?
Indeed!
from nextclade.
Related Issues (20)
- 3.0.0 version not retrieving RSV datasets HOT 1
- Can support be extended for SC2 Datasets V2 for another month? HOT 4
- Feature Request: Dataset download all datasets within specified path HOT 4
- Beginners Help with Nextclade CLI HOT 6
- Empty input file causes uncaught error in v3 (it didn't in v2)
- Erroneous Clade Assignment or More Refined Tool? HOT 4
- Add a BA.1 reference for the web nextclade version HOT 4
- error when using `nextclade dataset get --verbosity` flag HOT 3
- 21L Tree Updates? HOT 2
- `--input-pcr-primers` listed in CLI help options despite being removed in v3 HOT 2
- Scrollbar shown for dataset names in dataset picker HOT 9
- how to generate the result table by the cli version auspice HOT 4
- output TSV column(s) for missing bases at beginning and end of sequence? HOT 1
- --input-dataset parameter HOT 5
- Update Fred Hutch logo
- How to get the latest Lineage- with CLI HOT 4
- Community build cache validity bug HOT 2
- Developer guide uses deprecated CLI option
- docs: document nextalign-like use-case HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nextclade.