Comments (3)
I thought that maybe in future versions we want to liquidate users using a bot for that reason I put this functions. But for now I can remove them so the code will be cleaner and need less gas to deploy.
from nex-dex-contracts.
yes please, please make sure you save your valuable work locally (as will I) and then we can make this smart contract as lean as possible.
Being able to liquidate users was a requirement in the orderbook exchange, however right now it is no long a requirement.
Furthermore, we can still built in an orderbook in later versions on top of the vAMM ->
- two options:
- Users can post a limit buy/sell order offchain with us and we submit the order the moment a certain price is triggered
(this would be the low gas costs solution, but security risk for offchain getting hacked. - Second option: add the orderbook as you already built it on top of the vAMM , this would increase the complexity
onchain and the gas costs.
Im interested in your opinion.
Lets evaluate after the mvp, it does not have priority over the mvp and building out our product line.
from nex-dex-contracts.
Ok, I remove it for now because we don't need it.
from nex-dex-contracts.
Related Issues (20)
- oracle price split into TWAPoracle and liveOracle
- unintuitive sign HOT 2
- staying closer to the source code not to introduce an extra variable HOT 4
- What happens if user request zero withdrawal? HOT 4
- Why are you leaving 0.1? HOT 5
- add uniswap minimum amount out. HOT 3
- Could you type these functions out for me HOT 3
- Insurancefund = Liquidator? HOT 1
- Upper bound is bit high HOT 1
- Silver (and Gold probably same) contract price details HOT 1
- limit gas costs for setFundingRate by max users and min collateral deposit HOT 1
- Reduce fundingrate gas costs
- vulnerability report HOT 2
- Maximum call frequency setFundingRate HOT 3
- Cross contract collateral for hedged positions HOT 3
- Chainlink vrf HOT 3
- replace all BAYC and insurance refererences
- remove example contract warning HOT 1
- Before vulnerability report make overview smart contract vulnerability scanners
- Write article about wrapping staked tokens
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nex-dex-contracts.