Code Monkey home page Code Monkey logo

Comments (2)

Kunkka0822 avatar Kunkka0822 commented on August 11, 2024

@Waltermelon-lang
I will split this two functions - deposit and withdraw collateral.
Anyway, I am confusing regarding collateral balance because of unrealized and realized PNL.
Now we add or sub collateral value as unrealized profit or loss.
And in withdraw-collateral function, users can withdraw collateral from this.
https://github.com/nexlabs22/Nex-Dex-Contracts/pull/69
I couldn't see the difference of unrealized PNL and realized PNL.

from nex-dex-contracts.

Waltermelon-lang avatar Waltermelon-lang commented on August 11, 2024

When we realize unrealized profit
its like this:
collateral[usdc][_user] +-= pnl;
Where PNL is a variable not stored in memory. When unrealized PNL gets 'realized' it basically just means we are closing the position and transfer any remainder virtual usdc balance to the real usdc balance.
When we deposit or withdraw collateral, it has nothing to do with PNL, only with the collateral.
We don't work with 'realized' PNL as a variable afaik.
Hope this helps, please refer me some code lines if you have further unclarities.

from nex-dex-contracts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.