Comments (2)
@Waltermelon-lang
I will split this two functions - deposit and withdraw collateral.
Anyway, I am confusing regarding collateral balance because of unrealized and realized PNL.
Now we add or sub collateral value as unrealized profit or loss.
And in withdraw-collateral function, users can withdraw collateral from this.
https://github.com/nexlabs22/Nex-Dex-Contracts/pull/69
I couldn't see the difference of unrealized PNL and realized PNL.
from nex-dex-contracts.
When we realize unrealized profit
its like this:
collateral[usdc][_user] +-= pnl;
Where PNL is a variable not stored in memory. When unrealized PNL gets 'realized' it basically just means we are closing the position and transfer any remainder virtual usdc balance to the real usdc balance.
When we deposit or withdraw collateral, it has nothing to do with PNL, only with the collateral.
We don't work with 'realized' PNL as a variable afaik.
Hope this helps, please refer me some code lines if you have further unclarities.
from nex-dex-contracts.
Related Issues (20)
- oracle price split into TWAPoracle and liveOracle
- staying closer to the source code not to introduce an extra variable HOT 4
- What happens if user request zero withdrawal? HOT 4
- Why are you leaving 0.1? HOT 5
- add uniswap minimum amount out. HOT 3
- Could you type these functions out for me HOT 3
- Insurancefund = Liquidator? HOT 1
- Upper bound is bit high HOT 1
- Silver (and Gold probably same) contract price details HOT 1
- limit gas costs for setFundingRate by max users and min collateral deposit HOT 1
- Reduce fundingrate gas costs
- vulnerability report HOT 2
- Maximum call frequency setFundingRate HOT 3
- Cross contract collateral for hedged positions HOT 3
- Chainlink vrf HOT 3
- replace all BAYC and insurance refererences
- remove example contract warning HOT 1
- Before vulnerability report make overview smart contract vulnerability scanners
- Write article about wrapping staked tokens
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nex-dex-contracts.