newrelic / one-core-toolbox Goto Github PK

False positives

Capitalization

• "I've" -> "I've"
• "Git" -> "git"
• "Nerdpack" -> "nerdpack"
• "PRs" -> "prs"
• "10.2.0.1" capitalization
• "Android" -> "android"
• "Application performance monitoring" -> "application performance monitoring" (even though it was the first word in the sentence)
• "Dashboards" -> "dashboards" (even though it was the first word in the sentence)
• "Go" -> "go" (the language)
• "DevOps" -> "devops" (questionable)
• "CPU" -> "cpu"
• "Nginx" -> "nginx"
• "RedHat" -> "redhat"
• Instant "Observability" -> "observability (link)
• "Instant Observability" -> "instant observability"

Spelling

• "NPM" spelling
• "JVM" spelling
• "2:41PM" -> "2:41STM" (submitted an issue and a PR)
• "https" spelling
• "Feb" spelling
• "uncheck" -> "recheck"
• "prepopulated" -> "repopulated" (should be "pre-populated")
• "IDE" spelling
• "CDN" spelling
• "customizable" spelling (but it's correct)
• "jumpstart" -> "upstart" (should be "jump-start")
• Capitalization corrections displaying in lower case and then being applied as capitalized.

Equality

• "special" as insensitive language

Unknown rule

• "apm" -> "apm"
• "apache" -> "apache"
• "GDPR" -> "GDP"

Contractions

• "I have" -> "I've" (British style: I have five of those)
• "New Relic's" -> "New Relic"

Add a feature to the table creator which allows users to allow users to input one of the following:

• A CSV file
• A NRQL query
• Choose from commonly used tables (e.g. all entities, all dashboards, etc.)

Then we take that input and from it produce a One Core table.

• Update language in design linter tile to include language linter
• Add "new" badge to design linter tile or language linter language within that tile
  • This badge should be set to disappear after a certain date

No matter what we do, sometimes more text than available space in a cell. In New Relic One we handle that by truncating the text and placing an ellipsis (...) at the end of the visible text. We should do this for the table creator as well.

I wonder if I explain that you can select a parent and it's children layers will be linted in the empty state if it will be more clear.

In the color linter there are two links to "how to fix" which need to actually be hooked up to some page.

• The link in the description
• The button in the menu dropdown

For example:
Here it says 2 of 3 layers with issues but you can't navigate to the 3rd layer if it's really there.

Problem

Some users aren't even noticing the "format cells" button. Others don't know what "format cells" mean and I suspect they don't click it for that reason.

Proposed solution

Make the creation of tables a 2 step process
Here's the workflow I have in mind:

1. User chooses table dimensions
   • user clicks "continue"
2. User sets column configuration
   • User clicks "create table".

For example in this Figma file it happened to me but I'm having trouble reproducing it.

Another example

In New Relic One the width of columns is partly based on the amount of text in each column. We should do that same thing in the table create. For example, if I have 3 columns but column 2 has more text than the other columns then column 2 should be the widest.

To make it easier for users to see where the plugin did something.

Slack thread

I've received feedback that it's unclear what it's even for. Maybe the answer is to hide it when only one text layer is being listed.

Right now the plugin applies the same default sort icons to all column headers. We should make it so that users can set one of the columns to "sort by" so that the appropriate icon would applied to the column header cell.

Maybe in the bottom left corner of the CTA bar and in the empty state

The current empty state uses a mix of content from the plugin (the navigation) and content from the new-relic-language-linter NPM package for it's empty state. Replace both of these with an empty state provided completely by the plugin which has the same style as the empty state of the color linter.

When to display the empty state

• When there is no text layer selected
• When there is no layer selected
• The CTA should read "lint selected text layers"

Current	New

Figma groups by color when listing selection colors on a layer. Would this be helpful? Think through it.

Posible solution:

• Figma Developers Slack workspace thread
• React implementation

It looks like this may be an issue with the last color issue in the list

Right now, all tables are set to fixed with. We should allow users to set their table to fixed width if they prefer. Here's the difference

Requirements

Fixed width

• There must be a minimum width set based on the amount of text in the column
• The table is resized one column at a time by selecting the header cell of the column you want and resizing that header cell.
• The table can not be resized by clicking and dragging the table container

Fluid width

• The table is resized by clicking and dragging the table container
• The table can not be resized one column at a time.
• There must be a minimum width set based on the amount of text in the column

Note: How do we communicate the above details to the users? They're not intuitive.

Keep in mind that suggestions will help with this, but they may not be the whole solution.

This is feedback straight from @jeremenichelli:

When a cell is multivalue the whole Table is multivalue even if other cells don't have secondary values. I know that on the UI Kit each cell can be multivalue, but this has created tons of confusion, we should probably add it as a global setting in the Table or at least in your plugin impose it as a general config (once chosen it applies to all cells)

On numeric inputs in Figma you can click and drag the icon/label of the input to increase or decrease the number in the input. Here's an example of that interaction

We should implement this on our numeric inputs

Right now, the more columns and tables are included in the table the longer it takes to load. Up to like 5 or 6 seconds for a table that has max columns and max rows. We could use the number of columns and rows in the table (bonus points for factoring in cell types) to determine when to add a loading animation. A loading spinner that replaces the "Create table" button text could work well. That said, if it's just a 3x4 table or something small like that, I don't think a loading spinner is necessary.

Hey, team ✌🏽. I noticed an unexpected issue after my NR figma account was deactivated. It seems my Figma API key is no longer valid (which makes sense given my user was removed), but that means that the GitHub action which fetches the latest color tokens no longer works because the API key it's been provided is invalid.

I think that needs to be done to fix this is provide it with a valid Figma API key.

cc: @aarongarciah, @Bluefinger

Things to consider:

• Maybe we only mention this once at the top of the list.
• Maybe we store that message in a tooltip trigger on the tile.
• If there's no heading, it may look strange. Could we promote one of the pieces of meta data to be the heading?