Code Monkey home page Code Monkey logo

Comments (2)

NeVeSpl avatar NeVeSpl commented on May 27, 2024

Typewriter converts them to Date thus it will stay that way in NTypewriter too as default. But I see no reason why not to make it configurable as it was done in PR #7 with nullable types.

from ntypewriter.

gregveres avatar gregveres commented on May 27, 2024

Last night as I was comparing all the Urls created by NTypewriter to those created by Typewriter, I realized that I was wrong to request this "feature". I still believe that best practice is to pass dates between the front end and back end as strings and not DateTime/DateTimeOffset objects. But I remembered that you can't just "fix" it on the Typescript side, you have to make your DTO use string for those fields. My suggestion for best practice date handling is to never have your DTO include a DateTime or DateTimeOffset object, but instead use strings for those fields. This puts the proper handling of the conversion to and from the Date objects in your code's control, not hidden in some middleware.

I have closed the PR and I am closing this. If someone feels this is necessary, then the PR is still there and can be modified to suit, but I don't feel this is necessary. Sorry for the noise.

from ntypewriter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.