Action.ReturnType has is broken with introduction of TypedConstant. about ntypewriter HOT 6 CLOSED

Given the above, this is the output from a Debug.WriteLine type placed just inside the ImportType scriban function.

12:24:32.392 INFO: 4Sc4Hl5 Task<IHttpActionResult> AnnouncementsController.GetAllAnnouncements(int orgId)
12:24:32.392 INFO: 4Sc4Hl5 in ImportType for
12:24:32.392 INFO: 4Sc4Hl5 
12:24:32.392 INFO: 4Sc4Hl5 in ImportType for
12:24:32.392 INFO: 4Sc4Hl5 int

The first line of this output is from a Debug.WriteLine method that is placed just inside the for loop.

from ntypewriter.

I am pretty sure I have figured it out.
In the ReturnType function, you have the same issue that I had when you introduced the TypedConstant for the attribute arguments.

This line needs to be updated to take the TypedConstant into consideration.

from ntypewriter.

I thought I could make a copy of the ReturnType in my custom functions and then fix it there, but it is not as straight forward as expected. I have changed Action.ReturnType to Custom.ReturnType to call my function, but I am running into a type mismatch I think.

Here is the code I am trying:

        public static IType ReturnType(IMethod method)
        {
            var result = method.ReturnType;

            var responseTypeAttribute = method.Attributes.FirstOrDefault(a => a.Name == "ResponseType" || a.Name == "ProducesResponseType");
            var responseTypeArgument = responseTypeAttribute?.Arguments.FirstOrDefault(x => x.Name == "responseType" || x.Name == "Type");
            if (responseTypeArgument?.Value is ITypedConstant type) return type.Value as IType;

            while (result != null && (result.BareName == "Task" || result.BareName == "ActionResult"))
            {
                if (result.IsGeneric)
                {
                    result = result.TypeArguments.FirstOrDefault();
                }
                else
                {
                    result = null;
                }
            }
            return result;
        }

The issue I am running into is that the TypedConstant.Value isn't an IType so the "as IType" that used to be there still fails. The Value field is of the type:
`` Microsoft.CodeAnalysis.CSharp.Symbols.PublicModel.NonErrorNamedTypeSymbol```
casting this type to an IType causes the return value to be null.

from ntypewriter.

I have run out of ideas on how to extract the IType from responseTypeArgument.Value.Value. I have to roll back until there is a fix for this, unfortunately.

from ntypewriter.

Ugg, there doesn't seem to be a way to roll back.

from ntypewriter.

That is too many breaking changes, previous behaviour will return in 0.4.4.2, ITypedConstant will be only used for enums.

from ntypewriter.