import_data about ephypype HOT 6 CLOSED

Yes it seems fair, I do not remember where all these functions came from, but I believe they were related to the origin of the matlab timeseries or matrix, i.e. depending on how they were calculated.

• import_mat_to_conmat means the matlab file already contains a matrix, computed outside (with brainstorm or else)

• import_mat_to_conmat is when the "good channels" is a field within the matlab structure

• import_amplmat_to_ts is the same as _import_mat_to_ts it seems, so can be removed

• import_mat_to_ts seems a bit different, as the 'good_channels is based on the name of the strings in channel_names (EMG_ and EOG), I do not remember when it is used.

I have remove import_amplmat_to_ts, and merged import_mat_to_ts with _import_mat_to_ts (not implemented for the node, however...). I have renamed import_mat_to_conmat -> _import_mat_to_conmat and kept it, but is not used in node structure yet.

PR is here: #83

from ephypype.

On a side note: isn't it better to have a directory tests in each of the subdirectories where the tests functions or nodes are?

from ephypype.

Yes it seems fair, I do not remember where all these functions came from, but I believe they were related to the origin of the matlab timeseries or matrix, i.e. depending on how they were calculated.

* import_mat_to_conmat means the matlab file already contains a matrix, computed outside (with brainstorm or else)

* import_mat_to_conmat is when the "good channels" is a field within the matlab structure

* import_amplmat_to_ts is the same as _import_mat_to_ts it seems, so can be removed

* import_mat_to_ts seems a bit different, as the 'good_channels is based on the name of the strings in channel_names (EMG_ and EOG), I do not remember when it is used.

I have remove import_amplmat_to_ts, and merged import_mat_to_ts with _import_mat_to_ts (not implemented for the node, however...). I have renamed import_mat_to_conmat -> _import_mat_to_conmat and kept it, but is not used in node structure yet.

PR is here: #83

Hi David,

yes, I also thought it was something related to some thing of the past.
Thks for the PR.

I have some comments I'll write there.

from ephypype.

On a side note: isn't it better to have a directory tests in each of the subdirectories where the tests functions or nodes are?

Absolutely yes! in #81 I put the test of nodes, interfaces in the a folder "tests" that is a subdir of nodes, interfaces, ...

from ephypype.

On a side note: isn't it better to have a directory tests in each of the subdirectories where the tests functions or nodes are?

Absolutely yes! in #81 I put the test of nodes, interfaces in the a folder "tests" that is a subdir of nodes, interfaces, ...

OK I will do a merge of this version once accepted, and hopefully if will the coverage issue in #83

from ephypype.

close in #83

from ephypype.