Code Monkey home page Code Monkey logo

Comments (6)

davidmeunier79 avatar davidmeunier79 commented on September 7, 2024

format_electrodes_xls is just a specific example from an Excel file, maybe it is better to be removed. The version ImportBrainVisaAscii could be removed as well, but if we want the package to handle multiples modalities, it may be good to have as much import format as possible, thus implying multiple packages. Having said that, this particular fuction requires the user to use export ascii frile from BrainVision, there are other ways to handle BrainVision data, possibly with numpy but evn better would be with neo (hence another optional package). What about make a test if the package is installed to allow the use of particular optional function?

from ephypype.

jasmainak avatar jasmainak commented on September 7, 2024

+1 to remove any code that is not used.

@annapasca @davidmeunier79 you have to explain to me why you need different nodes for different files. In MNE, you should be able to import brainvision to raw object. Why do you need another class/function for that?

from ephypype.

davidmeunier79 avatar davidmeunier79 commented on September 7, 2024

@jasmainak unfortunately life is not that simple. BrainVision is full of bugs, and when I had to interfere with it, and the export of BrainVision would be quite different depending on what you would have to export (type of EEG signal and intraEEG for example) and on what kind of analysis (windows segmenting, artefact removal, etc.). So I am not sure what you mean by "raw object", but it appeared to be easier in many cases to export it as ASCII. Having said that it has been a while since I touched it ...

from ephypype.

jasmainak avatar jasmainak commented on September 7, 2024

this is an MNE raw object: https://martinos.org/mne/dev/generated/mne.io.Raw.html. It's basically how you represent the multivariate time series in MNE along with the metadata.

Here is the reader for brainvision in MNE: https://www.martinos.org/mne/stable/generated/mne.io.read_raw_brainvision.html.

If there are bugs there, they should be fixed via pull requests instead of reinventing the wheel ...

from ephypype.

davidmeunier79 avatar davidmeunier79 commented on September 7, 2024

we are talking about a piece of code that was written 2 years ago:
https://github.com/davidmeunier79/neuropype_ephy/commits/master/neuropype_ephy/nodes/import_data.py
I am not even sure the read_raw_brainvision of MNE-python was developed at the time (see history).
if you feel like rewriting these functions in the new framework, you are welcome

from ephypype.

jasmainak avatar jasmainak commented on September 7, 2024

The brainvision reader is from 2013. See here: mne-tools/mne-python#878.

from ephypype.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.