networkservicemesh / cmd-nse-icmp-responder Goto Github PK

View Code? Open in Web Editor NEW

2.0 2.0 20.0 886 KB

License: Apache License 2.0

Dockerfile 2.28% Go 97.72%

cmd-nse-icmp-responder's Introduction

Archived

This repo has been archived. Network Service Mesh continues to be very actively developed in multiple repos.

What is Network Service Mesh

Network Service Mesh (NSM) is the Hybrid/Multi-cloud IP Service Mesh.

For more information, have a look at our website

Getting started

Get Started with our latest release

Docs

Documentation can be found on our website

Get involved

Information on getting involved: meetings, slack, etc can be found on our commmunity page

cmd-nse-icmp-responder's People

Contributors

Stargazers

Watchers

cmd-nse-icmp-responder's Issues

Multiple IP addresses appearing in NSE and NSC after upgrade

During upgrade test with nse-icmp-responder and kernel2kernel example multiple interfaces appear in NSE with multiple IP addresses appear in NSE. NSC pods also get multiple addresses.
Before upgrade, the NSE looks like:

1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet 127.0.0.1/8 scope host lo
       valid_lft forever preferred_lft forever
2: tunl0@NONE: <NOARP> mtu 1480 qdisc noop state DOWN group default qlen 1000
    link/ipip 0.0.0.0 brd 0.0.0.0
4: eth0@if28559: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1430 qdisc noqueue state UP group default 
    link/ether f6:78:de:28:16:66 brd ff:ff:ff:ff:ff:ff link-netnsid 0
    inet 192.168.149.48/32 scope global eth0
       valid_lft forever preferred_lft forever
5: icmp-respo-37e0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 9000 qdisc mq state UNKNOWN group default qlen 1000
    link/ether 02:fe:4f:e2:31:12 brd ff:ff:ff:ff:ff:ff
    inet 172.16.1.96/32 scope global icmp-respo-37e0
       valid_lft forever preferred_lft forever
    inet6 fe80::fe:4fff:fee2:3112/64 scope link 
       valid_lft forever preferred_lft forever

After upgrade:

1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet 127.0.0.1/8 scope host lo
       valid_lft forever preferred_lft forever
2: tunl0@NONE: <NOARP> mtu 1480 qdisc noop state DOWN group default qlen 1000
    link/ipip 0.0.0.0 brd 0.0.0.0
4: eth0@if28559: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1430 qdisc noqueue state UP group default 
    link/ether f6:78:de:28:16:66 brd ff:ff:ff:ff:ff:ff link-netnsid 0
    inet 192.168.149.48/32 scope global eth0
       valid_lft forever preferred_lft forever
6: icmp-respo-fb43: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 9000 qdisc mq state UNKNOWN group default qlen 1000
    link/ether 02:fe:60:83:30:c0 brd ff:ff:ff:ff:ff:ff
    inet 172.16.1.96/32 scope global icmp-respo-fb43
       valid_lft forever preferred_lft forever
    inet 172.16.1.98/32 scope global icmp-respo-fb43
       valid_lft forever preferred_lft forever
    inet6 fe80::fe:60ff:fe83:30c0/64 scope link 
       valid_lft forever preferred_lft forever
7: icmp-respo-6de2: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 9000 qdisc mq state UNKNOWN group default qlen 1000
    link/ether 02:fe:74:98:66:90 brd ff:ff:ff:ff:ff:ff
    inet 172.16.1.96/32 scope global icmp-respo-6de2
       valid_lft forever preferred_lft forever
    inet 172.16.1.98/32 scope global icmp-respo-6de2
       valid_lft forever preferred_lft forever
    inet 172.16.1.100/32 scope global icmp-respo-6de2
       valid_lft forever preferred_lft forever
    inet6 fe80::fe:74ff:fe98:6690/64 scope link 
       valid_lft forever preferred_lft forever

NSC before upgrade:

1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet 127.0.0.1/8 scope host lo
      valid_lft forever preferred_lft forever
2: tunl0@NONE: <NOARP> mtu 1480 qdisc noop state DOWN group default qlen 1000
    link/ipip 0.0.0.0 brd 0.0.0.0
4: eth0@if28558: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1430 qdisc noqueue state UP group default 
    link/ether aa:b1:79:d5:54:8c brd ff:ff:ff:ff:ff:ff link-netnsid 0
    inet 192.168.149.18/32 scope global eth0
       valid_lft forever preferred_lft forever
5: nsm-1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 9000 qdisc mq state UNKNOWN group default qlen 1000
    link/ether 02:fe:f8:1e:a1:43 brd ff:ff:ff:ff:ff:ff
    inet 172.16.1.97/32 scope global nsm-1
       valid_lft forever preferred_lft forever
    inet6 fe80::fe:f8ff:fe1e:a143/64 scope link tentative 
       valid_lft forever preferred_lft forever

NSC after upgrade:

1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet 127.0.0.1/8 scope host lo
       valid_lft forever preferred_lft forever
2: tunl0@NONE: <NOARP> mtu 1480 qdisc noop state DOWN group default qlen 1000
    link/ipip 0.0.0.0 brd 0.0.0.0
4: eth0@if28558: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1430 qdisc noqueue state UP group default 
    link/ether aa:b1:79:d5:54:8c brd ff:ff:ff:ff:ff:ff link-netnsid 0
    inet 192.168.149.18/32 scope global eth0
       valid_lft forever preferred_lft forever
6: nsm-1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 9000 qdisc mq state UNKNOWN group default qlen 1000
    link/ether 02:fe:10:f1:00:35 brd ff:ff:ff:ff:ff:ff
    inet 172.16.1.97/32 scope global nsm-1
       valid_lft forever preferred_lft forever
    inet 172.16.1.99/32 scope global nsm-1
       valid_lft forever preferred_lft forever
    inet 172.16.1.101/32 scope global nsm-1
       valid_lft forever preferred_lft forever
    inet6 fe80::fe:afff:fe2e:dad6/64 scope link 
       valid_lft forever preferred_lft forever

Traffic was OK during the upgrade using the original IP (it stopped during pod restart, but after that came back as it should), but after the upgrade, the multiple addresses confused our tests, this is how the issue was detected.
The issue is reproducable, sometimes only one new IP appears, sometimes 2, as in the example.
I attached logs for the test case execution.

Versions used:
nsmgr=f2f421a
registry-memory=4b0bb64
forwarder-vpp=4e1d713
nse-icmp-responder-vpp=9b4b3fa
nsc-vpp=4c53be1

As upgrade base, we used versions from 19th of November:
nsmgr=47451a4
registry-memory=f24d424
forwarder-vpp=1b74b40
nse-icmp-responder-vpp=5ac470e
nsc-vpp=888fbd4

endpoint-nsc-684f87c977-2npct-nsc.txt
endpoint-nse-588cc4f7bb-xrnts-nse.txt
forwarder-vpp-jv7xh-forwarder-vpp.txt
nsmgr-v7spq-nsmgr.txt
nsm-registry-5c6dc57b69-hd7wz-registry-memory.txt

ICMP responder connection breaks after NSM upgrade

We would like to use the nse-icmp-responder and nsc endpoint kernel2kernel example for NSM upgrade tests. Our tests fail, the connection is OK before 'helm upgrade', but after the upgrade the connection between NSE and NSC is usually lost. (NSE and NSC are not upgraded, only the NSM infrastructure below them.) The behavior is not entirely deterministic, in some cases multiple interfaces appear in the NSE after the upgrade with conflicting IP addresses.

For example:

Before the upgrade (ping OK):

NSC:

kubectl exec -n nsm endpoint-nsc-7789d64bcc-wc7p5 -- ip addr show
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet 127.0.0.1/8 scope host lo
       valid_lft forever preferred_lft forever
2: tunl0@NONE: <NOARP> mtu 1480 qdisc noop state DOWN qlen 1000
    link/ipip 0.0.0.0 brd 0.0.0.0
4: eth0@if194402: <BROADCAST,MULTICAST,UP,LOWER_UP,M-DOWN> mtu 1430 qdisc noqueue state UP 
    link/ether 66:82:28:2c:47:4c brd ff:ff:ff:ff:ff:ff
    inet 192.168.215.162/32 scope global eth0
       valid_lft forever preferred_lft forever
194404: nsm-1@if194403: <BROADCAST,MULTICAST,UP,LOWER_UP,M-DOWN> mtu 9000 qdisc noqueue state UP qlen 1000
    link/ether e6:0b:fb:1a:cf:54 brd ff:ff:ff:ff:ff:ff
    inet 172.16.1.97/32 scope global nsm-1
       valid_lft forever preferred_lft forever
    inet6 fe80::e40b:fbff:fe1a:cf54/64 scope link 
       valid_lft forever preferred_lft forever

NSE:

kubectl exec -n nsm endpoint-nse-5bd8b66987-bwj4l -- ip addr show
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet 127.0.0.1/8 scope host lo
       valid_lft forever preferred_lft forever
2: tunl0@NONE: <NOARP> mtu 1480 qdisc noop state DOWN qlen 1000
    link/ipip 0.0.0.0 brd 0.0.0.0
4: eth0@if194401: <BROADCAST,MULTICAST,UP,LOWER_UP,M-DOWN> mtu 1430 qdisc noqueue state UP 
    link/ether 6e:b7:f4:fc:1f:88 brd ff:ff:ff:ff:ff:ff
    inet 192.168.215.142/32 scope global eth0
       valid_lft forever preferred_lft forever
194406: icmp-respo-f913@if194405: <BROADCAST,MULTICAST,UP,LOWER_UP,M-DOWN> mtu 9000 qdisc noqueue state UP qlen 1000
    link/ether fa:3c:f2:96:2d:f2 brd ff:ff:ff:ff:ff:ff
    inet 172.16.1.96/32 scope global icmp-respo-f913
       valid_lft forever preferred_lft forever
    inet6 fe80::f83c:f2ff:fe96:2df2/64 scope link 
       valid_lft forever preferred_lft forever

After the upgrade (connection lost):

NSC:

kubectl exec -n nsm endpoint-nsc-7789d64bcc-wc7p5 -- ip addr show
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet 127.0.0.1/8 scope host lo
       valid_lft forever preferred_lft forever
2: tunl0@NONE: <NOARP> mtu 1480 qdisc noop state DOWN qlen 1000
    link/ipip 0.0.0.0 brd 0.0.0.0
4: eth0@if194402: <BROADCAST,MULTICAST,UP,LOWER_UP,M-DOWN> mtu 1430 qdisc noqueue state UP 
    link/ether 66:82:28:2c:47:4c brd ff:ff:ff:ff:ff:ff
    inet 192.168.215.162/32 scope global eth0
       valid_lft forever preferred_lft forever
194409: nsm-1@if194408: <BROADCAST,MULTICAST,UP,LOWER_UP,M-DOWN> mtu 9000 qdisc noqueue state UP qlen 1000
    link/ether b6:9e:d6:9b:ec:b3 brd ff:ff:ff:ff:ff:ff
    inet 172.16.1.97/32 scope global nsm-1
       valid_lft forever preferred_lft forever
    inet 172.16.1.99/32 scope global nsm-1
       valid_lft forever preferred_lft forever
    inet6 fe80::b49e:d6ff:fe9b:ecb3/64 scope link 
       valid_lft forever preferred_lft forever

NSE:

kubectl exec -n nsm endpoint-nse-5bd8b66987-bwj4l -- ip addr show
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet 127.0.0.1/8 scope host lo
       valid_lft forever preferred_lft forever
2: tunl0@NONE: <NOARP> mtu 1480 qdisc noop state DOWN qlen 1000
    link/ipip 0.0.0.0 brd 0.0.0.0
4: eth0@if194401: <BROADCAST,MULTICAST,UP,LOWER_UP,M-DOWN> mtu 1430 qdisc noqueue state UP 
    link/ether 6e:b7:f4:fc:1f:88 brd ff:ff:ff:ff:ff:ff
    inet 192.168.215.142/32 scope global eth0
       valid_lft forever preferred_lft forever
194406: icmp-respo-f913@if194405: <BROADCAST,MULTICAST,UP,LOWER_UP,M-DOWN> mtu 9000 qdisc noqueue state UP qlen 1000
    link/ether fa:3c:f2:96:2d:f2 brd ff:ff:ff:ff:ff:ff
    inet 172.16.1.96/32 scope global icmp-respo-f913
       valid_lft forever preferred_lft forever
    inet6 fe80::f83c:f2ff:fe96:2df2/64 scope link 
       valid_lft forever preferred_lft forever
194411: icmp-respo-57e2@if194410: <BROADCAST,MULTICAST,UP,LOWER_UP,M-DOWN> mtu 9000 qdisc noqueue state UP qlen 1000
    link/ether de:61:0c:9d:e4:d3 brd ff:ff:ff:ff:ff:ff
    inet 172.16.1.96/32 scope global icmp-respo-57e2
       valid_lft forever preferred_lft forever
    inet 172.16.1.98/32 scope global icmp-respo-57e2
       valid_lft forever preferred_lft forever
    inet6 fe80::dc61:cff:fe9d:e4d3/64 scope link 
       valid_lft forever preferred_lft forever

After a minute:

NSC:

kubectl exec -n nsm endpoint-nsc-7789d64bcc-wc7p5 -- ip addr show
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet 127.0.0.1/8 scope host lo
       valid_lft forever preferred_lft forever
2: tunl0@NONE: <NOARP> mtu 1480 qdisc noop state DOWN qlen 1000
    link/ipip 0.0.0.0 brd 0.0.0.0
4: eth0@if194402: <BROADCAST,MULTICAST,UP,LOWER_UP,M-DOWN> mtu 1430 qdisc noqueue state UP 
    link/ether 66:82:28:2c:47:4c brd ff:ff:ff:ff:ff:ff
    inet 192.168.215.162/32 scope global eth0
       valid_lft forever preferred_lft forever
194414: nsm-1@if194413: <BROADCAST,MULTICAST,UP,LOWER_UP,M-DOWN> mtu 9000 qdisc noqueue state UP qlen 1000
    link/ether fe:fe:22:ea:b5:88 brd ff:ff:ff:ff:ff:ff
    inet 172.16.1.97/32 scope global nsm-1
       valid_lft forever preferred_lft forever
    inet 172.16.1.101/32 scope global nsm-1
       valid_lft forever preferred_lft forever
    inet6 fe80::fcfe:22ff:feea:b588/64 scope link 
       valid_lft forever preferred_lft forever

NSE:

kubectl exec -n nsm endpoint-nse-5bd8b66987-bwj4l -- ip addr show
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet 127.0.0.1/8 scope host lo
       valid_lft forever preferred_lft forever
2: tunl0@NONE: <NOARP> mtu 1480 qdisc noop state DOWN qlen 1000
    link/ipip 0.0.0.0 brd 0.0.0.0
4: eth0@if194401: <BROADCAST,MULTICAST,UP,LOWER_UP,M-DOWN> mtu 1430 qdisc noqueue state UP 
    link/ether 6e:b7:f4:fc:1f:88 brd ff:ff:ff:ff:ff:ff
    inet 192.168.215.142/32 scope global eth0
       valid_lft forever preferred_lft forever
194406: icmp-respo-f913@if194405: <BROADCAST,MULTICAST,UP,LOWER_UP,M-DOWN> mtu 9000 qdisc noqueue state UP qlen 1000
    link/ether fa:3c:f2:96:2d:f2 brd ff:ff:ff:ff:ff:ff
    inet 172.16.1.96/32 scope global icmp-respo-f913
       valid_lft forever preferred_lft forever
    inet6 fe80::f83c:f2ff:fe96:2df2/64 scope link 
       valid_lft forever preferred_lft forever
194411: icmp-respo-57e2@if194410: <BROADCAST,MULTICAST,UP,LOWER_UP,M-DOWN> mtu 9000 qdisc noqueue state UP qlen 1000
    link/ether de:61:0c:9d:e4:d3 brd ff:ff:ff:ff:ff:ff
    inet 172.16.1.96/32 scope global icmp-respo-57e2
       valid_lft forever preferred_lft forever
    inet 172.16.1.98/32 scope global icmp-respo-57e2
       valid_lft forever preferred_lft forever
    inet6 fe80::dc61:cff:fe9d:e4d3/64 scope link 
       valid_lft forever preferred_lft forever
194416: icmp-respo-6c1c@if194415: <BROADCAST,MULTICAST,UP,LOWER_UP,M-DOWN> mtu 9000 qdisc noqueue state UP qlen 1000
    link/ether e2:c0:69:72:63:60 brd ff:ff:ff:ff:ff:ff
    inet 172.16.1.96/32 scope global icmp-respo-6c1c
       valid_lft forever preferred_lft forever
    inet 172.16.1.100/32 scope global icmp-respo-6c1c
       valid_lft forever preferred_lft forever
    inet6 fe80::e0c0:69ff:fe72:6360/64 scope link 
       valid_lft forever preferred_lft forever

Images used:

cmd-nse-icmp-responder 1.0.0
cmd-nsc 1.0.0
nsmgr 1.0.0
registry-memory 1.0.0
forwarder-vpp 1.0.0

kubectl version
Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.1", GitCommit:"5e58841cce77d4bc13713ad2b91fa0d961e69192", GitTreeState:"clean", BuildDate:"2021-05-12T14:18:45Z", GoVersion:"go1.16.4", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.4", GitCommit:"ec2760d6d916781de466541a6babb4309766c995", GitTreeState:"clean", BuildDate:"2021-02-27T17:18:03Z", GoVersion:"go1.15.8", Compiler:"gc", Platform:"linux/amd64"}

helm version
version.BuildInfo{Version:"v3.6.0", GitCommit:"7f2df6467771a75f5646b7f12afb408590ed1755", GitTreeState:"clean", GoVersion:"go1.16.3"}

[root@k8smaster cmd-nse-icmp-responder-main]# docker build .
[+] Building 32.8s (8/17) docker:default
=> [internal] load build definition from Dockerfile 0.0s
=> => transferring dockerfile: 854B 0.0s
=> [internal] load .dockerignore 0.0s
=> => transferring context: 2B 0.0s
=> [internal] load metadata for docker.io/library/alpine:latest 2.2s
=> [internal] load metadata for docker.io/library/golang:1.20.5-buster 2.2s
=> CACHED [runtime 1/2] FROM docker.io/library/alpine@sha256:eece025e432126ce23f223450a0326fbebde39cdf496a85d8c016293fc851978 0.0s
=> CACHED [go 1/3] FROM docker.io/library/golang:1.20.5-buster@sha256:eb3f9ac805435c1b2c965d63ce460988e1000058e1f67881324746362baf9572 0.0s
=> [internal] load build context 0.0s
=> => transferring context: 1.49kB 0.0s
=> ERROR [go 2/3] RUN go install github.com/go-delve/delve/cmd/[email protected] 30.5s

[go 2/3] RUN go install github.com/go-delve/delve/cmd/[email protected]:
30.42 go: github.com/go-delve/delve/cmd/[email protected]: github.com/go-delve/delve/cmd/[email protected]: Get "https://proxy.golang.org/github.com/go-delve/delve/cmd/dlv/@v/v1.8.2.info": dial tcp 142.251.42.241:443: i/o timeout

Dockerfile:5

3 | ENV CGO_ENABLED=0
4 | ENV GOBIN=/bin
5 | >>> RUN go install github.com/go-delve/delve/cmd/[email protected]
6 | RUN wget --no-verbose --output-document=- https://github.com/spiffe/spire/releases/download/v1.2.2/spire-1.2.2-linux-x86_64-glibc.tar.gz | tar xzf - -C /bin --strip=2 spire-1.2.2/bin/spire-server spire-1.2.2/bin/spire-agent
7 |

ERROR: failed to solve: process "/bin/sh -c go install github.com/go-delve/delve/cmd/[email protected]" did not complete successfully: exit code: 1

Who can helo me , how to fix it
thanks

Add onidle chain element into cmd-nse-icmp-responder and cover it by docker tests

Overview

We need to test the new onidle chain element.

Implementation details

Add onidle element into responder endpoint chain, and configure it to stop the server on callback.
Add timeout parameter to server config.
Timeout should be defined as a pointer in the config to allow to determine whether the corresponding environment variable is set. If env variable was not set, then we shouldn't add the element.
Add a test that checks that the server successfully dies on specified timeout.

References

networkservicemesh/sdk#892

Add env `GROUP_ID` to endpoints

Description

For supporting mutually aware NSEs add env variable GROUP_ID which defaults to empty string

Issue

part of networkservicemesh/api#121

Definition of done

Add field groupID to config for all nse cmd
Add this field to connection according to changes here networkservicemesh/sdk#1203
Test that variable setting works correctly

End to end DNS integration: Make cmd-nse-icmp-responder DNS configurable

Related to

networkservicemesh/sdk#825

Description

We need to add a possible pass DNS contexts via env to cmd-nse-icmp-responder

Implementation details

Add new field into env config for https://github.com/networkservicemesh/api/blob/master/pkg/api/networkservice/connectioncontext.pb.go#L434
If SearchDomains are passed add dnscontext/server into server chain as additionalFunctionallity.

Estimation

Create initial icmp-responder nse application

We've achieved next nsm applications: nsc, nsmgr, forwarder. For start testing, we need to migrate icmp-responder nse application.
Example:https://github.com/networkservicemesh/sdk/pull/221/files#diff-0289092949dd346f5fdfdc6486a2afb2R20

networkservicemesh / cmd-nse-icmp-responder Goto Github PK

cmd-nse-icmp-responder's Introduction

Archived

What is Network Service Mesh

Getting started

Docs

Get involved

cmd-nse-icmp-responder's People

Contributors

Stargazers

Watchers

Forkers

cmd-nse-icmp-responder's Issues

Dockerfile:5

Overview

Implementation details

References

Description

Issue

Definition of done

Related to

Description

Implementation details

Estimation

Recommend Projects

Recommend Topics

Recommend Org