networkservicemesh / .github Goto Github PK

View Code? Open in Web Editor NEW

0.0 0.0 12.0 112 KB

License: Apache License 2.0

.github's Introduction

Archived

This repo has been archived. Network Service Mesh continues to be very actively developed in multiple repos.

What is Network Service Mesh

Network Service Mesh (NSM) is the Hybrid/Multi-cloud IP Service Mesh.

For more information, have a look at our website

Getting started

Get Started with our latest release

Docs

Documentation can be found on our website

Get involved

Information on getting involved: meetings, slack, etc can be found on our commmunity page

.github's People

Contributors

Watchers

Forkers

edwarnicke nikitaskrynnik glazychev-art wazsone kranthi0918 d-uzlov lioneljouin bellycat77 dualbreath vitalygushin nordix

.github's Issues

Vulnerabilities in workflows

Some workflows have vulnerabilities:

We use hardcoded NSM_BOT_GITHUB_TOKEN in some of workflows
We use hardcoded organization name in some of workflows

Automate updating versing of 'go'

Motivation

Updating version of 'go' is a very monotonous and most importantly time-consuming task since we need to update all our repositories (https://github.com/networkservicemesh?q=&type=all&language=go&sort= we have 54 repos)

Solution

Create a workflow that will update all repos automatically.

Implementation (DRAFT)

The user with admin rights creates a branch in .github repoupdate/go_${version}
NSMBot creates PR into .github repo where update version of go (simply replaces string with version https://github.com/networkservicemesh/.github/blob/main/.github/workflows/build-and-test.yaml to new version from the branch name)
NSMBot merges the branch if everyting is OK
Right after merge the branch, workflow triggers and starts update other go repos. (We could re-use our expirience with releaing and use workflow_run event https://github.com/networkservicemesh/sdk/blob/main/.github/workflows/release.yaml#L3-L8)
The workflow uses matrix and fetch org job https://github.com/networkservicemesh/cmd-template/blob/main/.github/workflows/update-cmd-repositories.yaml#L9-L20 to get the list of repos
Checkout repo from the list https://github.com/networkservicemesh/cmd-template/blob/main/.github/workflows/update-cmd-repositories.yaml#L30-L35
replace strings with go version in go mod and in ./workflow folder
install new version of go
run go mod tidy
if Dockerfile is exsist then we should update version of the docker image https://github.com/networkservicemesh/cmd-nsc/blob/main/Dockerfile#L1
commit changes as NSMBot and open PR (just push a brach update/go_$version into target repo)
NSMBot automaticcaly will create a PR and if ci will pass then the update will be merged (this step is already done)

Add reusable workflows for all cmd repositories to get rid of sync with cmd/template

Reusable workflows can improve CI and save from code duplication. Within this issue we add reusable workflows for cmd repos and remove cmd/template sync code since it will be no more needed.

Add reusable workflows for all sdk repositories

Description

Reusable workflows can improve CI and save from code duplication. First we can try to use them on sdk repository to check if it works. Then we can change all sdk repositories.

Fix warnings in common github actions

Make sure that organisation env KUBERNETES_VERSION is used correctly in all K8s integration repos

Description

Check all jobs in integration k8s aws/interdomain/gke/packet/aks/kind
Make sure that all single jubs (except jobs with version permutation) are using KUBERNETES_VERSION

Use Github CLI to create releases

Our release workflow uses Github Action that hasn't been supported since 2021. We should use Github CLI instead:

gh release create "${tag}" --title="${title}"

Add CVE scanner

"Permission tests" job runs even if there aren't tests require permission in the repo

Actual

Tests with permission cost 2.5m in SDK per run

Expected

Tests with permission should cost 0m in SDK per run (because no tests with permission in sdk)

Build

https://github.com/networkservicemesh/sdk/actions/runs/5725018079/job/15512654809

Remove or replace deprecated golang linters

We have deprecated golang linters across all repos.

Info

level=warning msg="[runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused."
level=warning msg="[runner] The linter 'scopelint' is deprecated (since v1.39.0) due to: The repository of the linter has been deprecated by the owner. Replaced by exportloopref."
level=warning msg="[runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused."
level=warning msg="[runner] The linter 'interfacer' is deprecated (since v1.38.0) due to: The repository of the linter has been archived by the owner. "
level=warning msg="[runner] The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner. Replaced by revive."
level=warning msg="[runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused."