As far as I understand it, adding this module to my Django project makes the entire application GPL. This makes usage in a professional setting difficult.

I fully agree with the principle of avoiding lock-in and of having something based on your work being shared with the community, but it's a little excessive to force this on the entire application for what is in all honesty a relatively minor component of the stack.

I would gladly contribute to djangocms-page-sitemap if I make any changes to it... I'm a little less comfortable in sharing all my work and forcing my customers to do the same.

I would suggest changing the license to LGPLv3 which doesn't have the "viral" attribute of the GPL but still keeps all the other freedoms intact.

GPL is usually for entire applications, LGPL for libraries or modules.

Thank you.

Your plugin has no migrations, suddenly.

Hi there,

So I start working in a company that uses Django cms. They have three different sitemaps.
One using your extensions, and the other two using the Django sitemap.
Your extension provides the nice menu tool, so I was trying to convert the other two sitemaps to use your extension.
When I'm trying to change one of the Django sitemaps to use the extension, I'm getting two identical sitemaps. The sitemap that originally used the extension.
Any idea why?
In urls I didn't change anything. And inside the sitemap, I converted it from:

from .models import Post
from django.contrib.sitemaps import Sitemap

class PostSitemap(Sitemap):
changefreq = "weekly"
protocol = "https"

def items(self):
    return Post.objects.filter(is_published=True)

def lastmod(self, obj):
    return max(obj.changed_at.date(), obj.pub_date)

def priority(self, obj):
    return obj.priority

to:
from djangocms_page_sitemap.sitemap import ExtendedSitemap

class PostSitemap(ExtendedSitemap):
protocol = "https"

Any suggestions?

We should add a flag to mark a page as "noindex" and add a templatetag to output the correct markup

This could also belong to https://github.com/nephila/djangocms-page-meta/

Description

The addon can not be uploaded to Divio Cloud because of an serialization issue.

Steps to reproduce

Try to upload the addon to Divio cloud

Versions

Expected behaviour

The upload should work.

Actual behaviour

Receive a serialization issue

Additional information

Issue was already discussed. This is the request ticket for the PR.

I have a multilanguage page and properties that i set for one language change properties for all rest languages.

I think it is a common bug and it dont need a steps to reproduce.

Dependabot couldn't authenticate with https://pypi.python.org/simple/.

You can provide authentication details in your Dependabot dashboard by clicking into the account menu (in the top right) and selecting 'Config variables'.

View the update logs.

ciao, i set up the djangocms-page-sitemap as described in the README and it works, meaning there's a properly rendered sitemap.xml. there's also a table djangocms_page_sitemap_pagesitemapproperties in the database.

however i do not see an interface to alter the properties in the admin-backend, nor corresponding inline fields in an admin interface for a page.

am i missing something or can this be considered as bug?

OS: Ubuntu Trusty
Python: 3.4.3
Django: 1.8.12
Django CMS: 3.2.3
Django CMS Page Sitemap: 0.3.1

I'd like to backport noindex feature to 0.4 branch

Hi, we are using your plugin and sometimes I am receiving this 'deprecatedwarning' for the utils file.

/home/jeroenpeters1986/.virtualenvs/website/local/lib/python2.7/site-packages/djangocms_page_sitemap/utils.py:11: UserWarning: Pages no longer have a "site_id" attribute. To get the site id of any given page, call "site_id" on the page "node" object. This backwards compatible shim will be removed in version 3.6

Is this something you are familiair with and has an "easy" fix?

After 0.4.2 release, drop support for older django CMS

Description

Switch to Coveralls Github action

Description

Migrate to bump-my-version

Update metadata regarding python, django version support

Apparently the toolbar is not registered ???

Hi,

at first I want to say thank you for this great extension, this is exactly what I need! 👍

But could you explain, why the extra robot values field is mandatory?

Thanks and best,
Chris

We should drop self-baked BaseTest class here and reuse the djangocms-helper logic

the get_cache_key function in utils includes:

from cms.templatetags.cms_tags import _get_cache_key

In django cms 3.1

_get_cache_key 

has been moved to

cms.cache.__init__

Description

After 'djangocms_page_sitemap' is added to INSTALLED_APPS,
page types cannot be displayed

Steps to reproduce

1. Install a django-cms site

python3 -m venv env
pip install --upgrade pip
pip install wheel
. env/bin/activate
pip install --upgrade pip
pip install wheel
pip install djangocms-installer
djangocms --django-version 2.2 mysite # same problem with 3.1
pip install djangocms-page-sitemap
cd mysite/
./manage.py runserver

2. Connect as admin/admin
3. Add a home page
4. Add the page type "Type 1" with slug "type1"
5. Display http://localhost:8000/en/page_types/type-1/

That's OK. Now:

6. Edit mysite/settings.py to add 'djangocms-page-sitemap' to INSTALLED_APPS
7. Migrate and start server

./manage.py migrate
./manage.py runserver

8. Try to display the page type http://localhost:8000/en/page_types/type-1/

TypeError at /en/page_types/type-1/

Versions

Python 3.8.6, Django==2.2.18, django-cms==3.8.0, djangocms-page-sitemap==1.0.0

Actual behaviour

Internal Server Error: /en/page_types/type-1/
Traceback (most recent call last):
  File "django/core/handlers/exception.py", line 34, in inner
    response = get_response(request)
  File "django/core/handlers/base.py", line 145, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "django/core/handlers/base.py", line 143, in _get_response
    response = response.render()
  File "django/template/response.py", line 106, in render
    self.content = self.rendered_content
  File "/django/template/response.py", line 83, in rendered_content
    content = template.render(context, self._request)
  File "django/template/backends/django.py", line 61, in render
    return self.template.render(context)
  File "django/template/base.py", line 171, in render
    return self._render(context)
  File "django/template/base.py", line 163, in _render
    return self.nodelist.render(context)
  File "django/template/base.py", line 937, in render
    bit = node.render_annotated(context)
  File "django/template/base.py", line 904, in render_annotated
    return self.render(context)
  File "django/template/loader_tags.py", line 150, in render
    return compiled_parent._render(context)
  File "django/template/base.py", line 163, in _render
    return self.nodelist.render(context)
  File "django/template/base.py", line 937, in render
    bit = node.render_annotated(context)
  File "django/template/base.py", line 904, in render_annotated
    return self.render(context)
  File "classytags/core.py", line 151, in render
    return self.render_tag(context, **kwargs)
  File "sekizai/templatetags/sekizai_tags.py", line 87, in render_tag
    rendered_contents = nodelist.render(context)
  File "django/template/base.py", line 937, in render
    bit = node.render_annotated(context)
  File "django/template/base.py", line 904, in render_annotated
    return self.render(context)
  File "classytags/core.py", line 151, in render
    return self.render_tag(context, **kwargs)
  File "cms/templatetags/cms_tags.py", line 443, in render_tag
    return toolbar.render_with_structure(context, nodelist)
  File "cms/toolbar/toolbar.py", line 467, in render_with_structure
    self.populate()
  File "cms/toolbar/toolbar.py", line 407, in populate
    self._call_toolbar('populate')
  File "cms/toolbar/toolbar.py", line 434, in _call_toolbar
    getattr(toolbar, func_name)()
  File "djangocms_page_sitemap/cms_toolbars.py", line 37, in populate
    position = current_page_menu.find_first(Break, identifier=PAGE_MENU_THIRD_BREAK) - 1
TypeError: unsupported operand type(s) for -: 'NoneType' and 'int'
[11/Feb/2021 16:02:06] "GET /en/page_types/type-1/ HTTP/1.1" 500 168859

Add addon.json to make this package installable via https://github.com/nephila/django-app-enabler

You have no translations for UI. Could you add your project to transefix?

Hi everyone at Nephila . Thank you for this wonderful package.

It throws this error on Django CMS 3.6. You might already know what's going on. There's a similar request on other package that might help: divio/aldryn-newsblog#522

I can make a PR later today if it helps.

Thanks!

Marcos