nephics / noxmox Goto Github PK

https://github.com/nephics/noxmox/blob/master/mox.js#L305 does not create a fully qualified url, which will break code that use other s3 libraries like knox for their "real" S3 interaction.

windows with proper user control settings requires admin privileges to write anything to root, including the c:\tmp\nox dir that noxmox tries to make. Instead, on the win32 platform there is the TEMP var that indicates the current user's temp folder location, so you could do something like

if (!options.prefix) {
  if (process.platform === "win32") {
    options.prefix = process.env["TEMP"] + "/mox";
  } else {
    options.prefix = '/tmp/mox';
  }
}

on https://github.com/nephics/noxmox/blob/master/mox.js#L84 (windows doesn't care about \ vs / and will happily navigate and serve data from locations that mix the two, or even exclusively use /)

interesting mox problem: calling a put("thing") will create a file "thing" in the temp dir that mox is using, and using a miniserver to serve that data shows it's there, and works great (after making the mini server serve everything as text/html content).

However, "thing" is not necessarily a file, just a URI that hides, for instance, "thing/index.html".

Performing a put("thing/edit") makes mox throw a 403 AccessDenied error, because it doesn't know what to do: "thing/edit" look like it should be a dir "thing" with a file "edit" in it, but it can't make that dir because there's already a file called "thing".

This might need a check to see if a put-path is being request for which one or more parts of the path are actually files, and do some kind of file-to-dir resolution, moving the file to .../index.html instead

Hi, knox had a problem with unicode in URLs that got fixed in Automattic/knox@6f2ad0d that I think mox might also be suffering from, where unicode characters in URLs are not getting escaped correctly, leading to an illegal URL when trying to store them.

This is excellent, but I notice there's a difference between knox and noxmox, url function of client is missing. Is there a reason it was removed?