nepherhotep / django-rest-framework-dyn-serializer Goto Github PK

Hello,

I am using Django rest framework 3.6.4 and I am getting the following error:

File "/home/vagrant/.virtualenvs/api/lib/python3.6/site-packages/rest_framework_dyn_serializer.py", line 44, in init
field_name.context = self.context
AttributeError: can't set attribute

I think that the error is related to the following change in the version 3.6.4:

encode/django-rest-framework@563020e

You can see in the line 599 that @cached_property is not longer used, and it was replaced for @Property, I think that the (for in ) in line https://github.com/Nepherhotep/django-rest-framework-dyn-serializer/blob/master/rest_framework_dyn_serializer.py#L43 is not need anymore, but I am not totally sure.

Regards.

Here is an example taken from test with a little change

# Pass limit_fields = False to nested serializer
class ArticleDynSerializer(DynModelSerializer):
    author = AuthorDynSerializer(required=False, limit_fields=False)

    class Meta:
        model = Article
        fields_param = 'article_fields'
        fields = ['id', 'title', 'created', 'updated', 'content', 'author']

class ArticleViewSet(viewsets.ReadOnlyModelViewSet):
    queryset = Article.objects.all().order_by('id')

    def get_serializer(self, *args, **kwargs):
        context = self.get_serializer_context()
        context['request'] = self.request
        s = ArticleDynSerializer(*args, context=context, limit_fields=True, **kwargs)
        return s

In such case author serializer behaves like dynamic in spite of limit_fields is set to False. So all fields for nested serializers always must be defined explicitly in the request.

what is self.nested

Is it possible to limit fields when declared so that a model serializer can be re-used, e.g:

UserModelSerializer(fields=('id', 'first_name', 'last_name',))

This way I can re-use the UserModelSerializer in other places without exposing additional info such as username, email etc when nesting it.