nemomobile / nemo-keepalive Goto Github PK

Currently BackgroundJob always triggers immediately when enabled is set to true. There's also no way to tell BackgroundJob to behave like a single-shot timer. Though it's certainly possible to work around this, by keeping track of whether the BackgroundJob has already triggered once and disabling it when you've done the work that needs to be done, it would be helpful if you could add the two boolean properties triggeredOnStart and repeat that work the QtQuick Timer type's properties of the same name.

Additionally, if enabled is set to false after finished() has already been called, BackgroundJob will still trigger once more. For a demonstration of this behaviour, take a look at this code, adapted from examples/qml/backgroundjob.qml (the only change is the removal of line 41, which normally hides the text when the BackgroundJob is disabled):

import QtQuick 2.0
import Sailfish.Silica 1.0
import org.nemomobile.keepalive 1.0

ApplicationWindow {
  initialPage: Page {
    Timer {
      id: timer
      interval: 1000
      repeat: true
      property int run_periods
      onTriggered: {
        if (--run_periods == 0) {
          backgroundJob.finished()
          stop()
        }
      }
    }

    BackgroundJob {
      id: backgroundJob
      frequency: BackgroundJob.ThirtySeconds
      onTriggered: {
        timer.run_periods = 5
        timer.running = true
      }
    }

    Column {
        width: parent.width
        spacing: Theme.paddingLarge
        anchors.centerIn: parent
        Label {
            anchors.horizontalCenter: parent.horizontalCenter
            text: backgroundJob.running ? "running job " + timer.run_periods : "job waiting"
        }
        Button {
            text: backgroundJob.enabled ? "Disable" : "Enable"
            anchors.horizontalCenter: parent.horizontalCenter
            onClicked: {
                backgroundJob.enabled = !backgroundJob.enabled
            }
        }
    }
  }
}

If you press the "Disable" Button while the Label displays "job waiting", the Timer will nevertheless be started again a few seconds later by the BackgroundJob, after which backgroundJob.running will be perpetually set to true, i.e. "running job 0" will be displayed.

This seems like very strange behaviour to me. I would definitely not expect the BackgroundJob to trigger again in spite of its enabled property being set to false.