nejdetkadir / followability Goto Github PK

Hi, i've got a question regarding the callback functions.

1) callback definition
In the readme it states the usage is like this:

def follow_request_accepted_by_me(record); end

but the run_callback method in callbacks.rb seems to run the callback method with two parameters?

2) callback parameter
from the readme file i thought i would always get the other model of the follow relationship in the callback as parameter,
but i guess i dont?

which i think translate to:

=> user_a.follow_request_accepted_by_me(user_a, :follow_request_accepted_by_me)

is this intentional? I would have expected something like this:

run_callback(self, affected: record, callback: :follow_request_accepted_by_me)
=> user_a.follow_request_accepted_by_me(user_b, :follow_request_accepted_by_me)

If it's not intentional I could try to make a pull request 👍

Example

@bar = nil
@foo.following?(@bar) -> false

Line 51 of follow.rb:

relation = followerable_relationships.find_by(followable_id: record.id,
followable_type: record.class.name,
status: Followable::Relationship.statuses[:following])

Changed to:
relation = followerable_relationships.find_by(followable_id: record.id,
followable_type: record.class.name,
status: Followability::Relationship.statuses[:following])

I was then able to unfollow users.

This should be the inverse of the blocks the same as following/followers are inverse of each other.

• unfollow_by_me -> unfollowed_by_me
• unfollow_by_someone -> unfollowed_by_someone

Hello,

I am considering using the followability gem for a Rails project that uses Mongoid as its database ODM instead of ActiveRecord. I was wondering if it is possible to integrate followability with Mongoid, and if so, how one might go about doing this. Any guidance or suggestions on modifications that might be required to support Mongoid would be greatly appreciated.

Thank you for your help!
Best Regards.

So, this arguments is a bug?

  def follow_request_sent_to_me(follower)
    message = "#{follower.username} has sent you a follow request"
    NotificationJob.perform_later(id, message)
  end