nehemiahk / fun-react-lib Goto Github PK

It would be nice to have a live preview of the project. Github pages should do the job.

Should collapse into a hamburger menu

The documentation should guide developers on how to go about the project files and the styling usage. i.eusing prettier where necessary to format code before pushing to the remote repository.

Hey all, I would like to implement an example modal component. There would be a button that says 'Open Modal' and it would close when either the 'close' button is clicked or the background behind it is clicked.

exclude .idea, .vscode etc.. folders from being added to the source by adding them to gitignore

While creating a lib, I believe we should keep on documenting our components.

We can use StoryBook for that purpose. It will help everyone to use and share components also for the new contributors to get onboarded.

Radio button component with option to add style via props.

We need to add pre-commit and pre-push hooks to our repo. This will make sure, anybody who is going to raise a PR to this repo, all the code is formatted and linting has been done.

Commit or push won't happen if there are linting errors. Later on, we can run tests as a condition to make sure that the code is clean and properly tested before it's up for PR.

We should add the eslint in our project so that the code is clean and properly linted and following the industry standards.

The styling of the components page changed a lot.

Any idea when this happened?

I see there is a navigation bar on top that doesn't do anything. And i sort of likes the component list on the left.

Not sure I want to deploy this version.

We can include some tools like Plop to create the basic files for the components. The script will:

• Create a .jsx file
• Create a .css/.scss file
• Create a .test.jsx file

This will basically work more like Angular's ng generate component. Which will give the starter files to work with.

We should not be using random font-sizes across the lib. Let's follow consistent typography.

For a reference, we can implement typography rules proposed by Material design.

The CSS/design is definitely lacking in this area

editorconfig should be enabled so as to enforce consistent code style across different environments.

Hi @NehemiahK, I just want to bring this point, let's try to keep the practice of merging the PRs with Squash and Merge option. This will help us to keep the commit history in master to be clean.

If anyone wants to go back to the commits, they can see that in the PR description.

Example commit history from one of my own project:

since many people will contribute and create components, it will be nice to have story book in this project,
as well - might add a storybook file to the script creating a component.
what ya think?

On the demo homepage the spinner is always showing when you first load the page until you click a tab and the home button doesn't actually do anything once you click a tab

Hi, I'm new to open source, I'd like to start here. I want to implement a card component to the library which consists of a fluid material-ish card component with a heading and a paragraph. Also I'd like to add a image to it as well.

We should integrate the CI/CD pipeline for the project.

CI pipeline will make sure that we are following the best practices before merging anything to master. We can have basic format-check and linting-check as of now and later on increase the scope of the CI pipeline.

CD pipeline is going to help us that gh-pages is up and running with the latest changes once the code is merged to the master branch.

Hey, I'm so happy this repo has been getting a lot of attention and people are really contributing. I could really use some help though managing the repo especially over the weekends when I'm less available.

I'm primarily looking for people who have a decent amount of experience in open source (bonus points for running your own repo).

If this isn't you, that's also fine. I could use help with people adding more issues. Anything from enhancements to new features.

All the best and happy coding!
Nehemiah

Let's define colors for the entire library to maintain same color palatte, otherwise the components will become inconsistent and look very different from each other. We can also move to sass for a hassle free implementation. I request everyone reading this to leave a comment on this..

import SimpleButton from 'components/Button';
instead of

import SimpleButton from '../components/Button';

Hello. I would like to implement a contact form. I would like to do just the front-end part as I am not that experienced with back-end. the form can have the name, email and message inputs and the send button.

Like the checkbox component with flare!