nebula-contrib / nebula-node Goto Github PK

@huaxiabuluo is working on a refactor of this project.

• remove 3pp package from the repo(leave them in package*.json only)
• introduce package-lock.json
• jest for test
• removed the thrift-gen code
• more(@huaxiabuluo to add more)

master...huaxiabuluo:nebula-node:master
PR: #27

@wujjpp what do you think? He assumed no modification of dep packages and thrift-gen code was not modified manually, for now the test cases passed but not sure if it could work in production, could you help advise on this proposal?

Thanks!

3.0.1 works fine, but 3.0.2 drops an error while importing ...
at line:
const { createClient } = require( '@nebula-contrib/nebula-nodejs' )

OS: MacOS 13.3.1
Node 20.1.0

Error: Cannot find module '/Users/vii/Ruse/Argus/argus-entitier/node_modules/@nebula-contrib/nebula-nodejs/index.js'. Please verify that the package.json has a valid "main" entry

as title

we do some second-dev on this project for Node client, it has been run for months in prod. we plan to donate it with new branch or other someway else you need, what process should us follow? this one https://docs.nebula-graph.com.cn/2.6.1/15.contribution/how-to-contribute/?

可以发相关资料给我吗？
或许我可以协助 开发

• manually published to npmjs repo: #10
• create CI to publish in nightly and release: #17
  • UT CI passed here https://github.com/nebula-contrib/nebula-node/runs/6823944486?
  • Test Release https://github.com/nebula-contrib/nebula-node/runs/6825833221?check_suite_focus=true

Hi!

Do you have any plans to evolve the node client?

Do you have any plans to rewrite it in TypeScript or at least add .d.ts type definitions?

Examples of the official drivers are written in TypeScript:

• Mongo - sources in TS, tests in JS.
  https://github.com/mongodb/node-mongodb-native
• Neo4j - mostly rewritten in TS.
  https://github.com/neo4j/neo4j-javascript-driver