ndlano / h5p-ndla-timeline Goto Github PK

Hello,

We've tried to activate or update your repository on Depfu and couldn't find any supported dependency files. If we were to guess, we would say that this is not actually a project Depfu supports and has probably been activated by error.

Monorepos

Please note that Depfu currently only searches for your dependency files in the root folder. We do support monorepos and non-root files, but don't auto-detect them. If that's the case with this repo, please send us a quick email with the folder you want Depfu to work on and we'll set it up right away!

How to deactivate the project

• Go to the Settings page of either your own account or the organization you've used
• Go to "Installed Integrations"
• Click the "Configure" button on the Depfu integration
• Remove this repo (NDLA-H5P/h5p-timeline) from the list of accessible repos.

Please note that using the "All Repositories" setting doesn't make a lot of sense with Depfu.

If you think that this is a mistake

Please let us know by sending an email to [email protected].

This is an automated issue by Depfu. You're getting it because someone configured Depfu to automatically update dependencies on this project.

Use case:

• in one Timeline slide Media part, create a link to a longish Wikipedia article extract (the length of the extract is automatically decided by Timeline, so you'll have to experiment)
• in the Description text part of the slide, type a longish text
• view the resulting timeline on a small screen (phone, or simulate view on desktop computer)
• the longish Description text features a scroll bar (highlighted in red on attached screenshot)
• the longish Wikipedia extract is cut and no scroll bar is available
  I have tried to add a CSS overflow: scroll; to various parts of the Media part of the slide but to no effect.
  

There are 2 ways to create/upload an H5P activity in Moodle:
method a) using the 3rd-party plugin provided by the H5P team (the black icon),
method b) using the core Moodle H5P activity (the blue icon).
In the current version of Moodle (4.2.x), h5p-ndla-timeline works OK using method a).
If using method b), it's possible to create/upload an h5p-ndla-timeline activity, but impossible to display it. Or rather there is a weird way of doing it. If you manage to click on the right of the line which is supposed to hold that content, it will open full screen and you will be able to view the content! But when you close/escape that full screen, it disappears again.

PS.- Interestingly I notice that there is exactly the same problem in LUMI... So not a bug special to Moodle core H5P.

Not an issue as such, but I'm surprised you renamed branch "main" to "master" recently. This seems to go against the general recommended trend on github. See for example https://www.theserverside.com/feature/Why-GitHub-renamed-its-master-branch-to-main

Time marker headline text font-size much too big! (screenshot 1). Adding this rule to the styles.scss file fixes it (screenshot 2).
h2.tl-headline.tl-headline-fadeout {
font-size: 12px!important;
}

Instructions at https://github.com/NDLANO/h5p-ndla-timeline#running say:
Open the file dist/index.html in your browser
Which does not work. there is no index.html file in the dist folder.
The following works for me:
Open the file node_modules/@knight-lab/timelinejs/dist/embed/index.html in your browser

I regret the absence of those two fields in h5p-ndla-timeline. They are available in the original timeline.knightlab libraries and very useful.

1.- npm install throws lots of errors, some but not all are fixed by running npm audit fix --force
2.- To create a production build: npm run build-prod should be: npm run build
3.- To create a development build: npm run build-dev should be npm run build:dev

On my local dev drupal 7 set up I fail to pack h5p-ndla-timeline correctly. I do h5p pack h5p-ndla-timeline h5p-ndla-timeline.h5p -r (using the -r parameter to add the dependencies).
In the resulting h5p-ndla-timeline.h5p archive there is no sign of the dist folder. Which means installing this library to another environment results in this Error message
The file "dist/bundle.js" is missing from library: "H5P.NDLATimeline-0.0"
The file "dist/bundle.css" is missing from library: "H5P.NDLATimeline-0.0"
The uploaded file was not a valid h5p package
Note.-
Given all the various issues with h5p-ndla-timeline that I have come across when trying to use it recently I wonder if this library has actually been tested on the various platforms where H5P libraries can be installed, e.g. WP, Moodle, Drupal... That's a pity because it has some useful elements which are missing from the current h5p timeline library. Or am I missingn some important information?

The instructions say:
To run in hot module reloading mode:
npm run watch
and on the following screen I see:
[webpack-dev-server] Project is running at:
[webpack-dev-server] Loopback: http://localhost:8080/
[webpack-dev-server] On Your Network (IPv4): http://192.168.1.18:8080/
If I try either http://localhost:8080/ or http://192.168.1.18:8080/ all I get is an error message: Cannot GET /
What am I doing wrong?