ncss-tech / jnsmr Goto Github PK

@dylanbeaudette pointed out an example of an extent (Coweeta) where all grid cells return "Perudic" moistureRegime with NA regimeSubdivision1 and regimeSubdivision2.

This has been partially addressed in 66c29b4 which modifies the factor levels assigned when there is a valid SMR but no subdivision. The " " values returned are converted to "Undefined" on R side for consistency in SpatRaster method regardless of extent. You get expected values when you use a larger (e.g. 10x coweeta) extent (that has more variation in SMR as well as defined subdivisions)

For a more general fix might need some adjustment in the Java code to make sure the values returned when the subdivision is "Undefined" are consistent. These values appear to be missing (NA) in the case where that is the only level, which is unexpected. Possibly a degenerate case in the Java batching method used by jNSMR:::batch2()

The " " values returned are converted to "Undefined" on R side for consistency, and this is what you get when you use a larger extent that has more variation in SMR as well as defined subdivisions

Looks like the current GH version is using newhall-1.6.4.jar. Any plans to enable XML output, or is there a better way?

Would be nice to have a short section in the manual page on how to interpret the results. Field names are mostly self-explanatory, but not all.

Would be nice to have some convivence functions for converting the output from e.g. fetchSCAN() into the format used in batch mode. Mostly preservation of IDs, long → wide format, etc..

There may be instances where the estimated PET in Newhall is unrealistic for one or more reasons.

One generic work around for this would be to allow an optional "crop coefficient" column/raster input that would allow for scaling/local modification of the PET->AET based on dominant vegetation, local experimental data, etc.

The cryic STR summer temperature criteria differ based on the presence or absence of O horizon and saturated conditions

Cryic (Gr. kryos, coldness; indicating very cold
soils).—Soils in this temperature regime have a mean annual temperature between 0 and 8 ᵒC but do 
not have permafrost.
1.  In mineral soils the mean summer soil temperature (June, July, and August in the Northern 
Hemisphere and December, January, and February in the Southern Hemisphere) either at a depth of 50 
cm below the soil surface or at a densic, lithic, or paralithic contact, whichever is shallower, is 
as follows:
a. If the soil is not saturated with water during some part of the summer and
(1) If there is no O horizon: between 0 and 15 ᵒC; or
(2) If there is an O horizon: between 0 and 8 ᵒC; or
b. If the soil is saturated with water during some part of the summer and
(1) If there is no O horizon: between 0 and 13 ᵒC; or
(2) If there is an O horizon or a histic epipedon: between 0 and 6 ᵒC.

• Saturation (@ 50cm) can be toggled for a single simulation
• O horizon presence/absence can be toggled for a single simulation
• The grid-based methods (SpatRaster) should allow for a presence/absence grids of saturation and O horizon to be supplied

These changes will be incorporated in PR #6 which seeks to fix calculation issues (and extend them) for frigid/cryic determination.