ncs-jss / plexus-17 Goto Github PK

Many middlewares can be used inside if statements.
For eg - Take isAdmin

router.get('/users', isAdmin, () => {
})

Good but sometimes we need the isAdmin functionality inside the route controller. Thus reusing the middleware seems a good enhancement

Check 4th point of https://github.com/airbnb/javascript/tree/master/react#naming

Make stand-alone services to interact with mongodb.
This is because most entities are interconnected, so it's very unlikely that only a single document will be accessed or modified.

Instead, changing one document of one collection would lead to change in one or more documents of other collections.

That is why abstracting away these mutliple queries into one single function, may lead to maintainable codebase

index shouldn't be used as key, instead the id should be used. This is to avoid issues on rearranging and on deletion of items.

Read this - https://medium.com/@robinpokorny/index-as-a-key-is-an-anti-pattern-e0349aece318

// bad
{todos.map((todo, index) =>
  <Todo
    {...todo}
    key={index}
  />
)}

// good
{todos.map(todo => (
  <Todo
    {...todo}
    key={todo.id}
  />
))}

The indentation value is set improperly. In many parts of the frontend, there are indentation of 2's and somewhere of 4's.

We would like to have indentation set to 2 everywhere.
Keep in mind about the fact that majority of code is jsx so if using a formatter configure it accordingly.

The frontend code is in client/ dir and hopefully most of the inconsistency also. However do check the whole project for it.
This could be a good way to understand the project structure and all the moving parts.

As we are using async/await syntax we should use try/catch blocks to handle errors.

Separate the project setup steps (one-time use) and running server steps (every-time use) from Readme to avoid confusion

The backend currently has 5 operations covering CRUD, which are

• get
• list
• create
• update
• remove

However in the client side redux action types, fetch_user and fetch_events has been used, this should be fixed

The create and manage functionality has many complicated conditions like who can create and who can edit.

But we can start it by first allowing the feature to admin only after that we'll work our ways to the other type of roles who can do this

Include the bootstrap framework library in the project and update the Header,js file to use the navbar bootstap component.

Saw issue number #25 with hacktoberfest label, and It would be nice to get a brief description what this project is about since more people are likely to discover this project and have no idea what this is.

• A user can't edit his role, verified etc.
• Admin can change any user's role.

To properly remedy this, joi scheme should not allow the role key in case of user but definitely allow it in case of admin.

It should be taken care properly.

Currently, in the user.service get method, we use the _id attribute to fetch that user. However in many cases we will not be having that id, because recieved API call from client may not expose it (id in address bar will look ugly). So other attributes should be accepted also

The current workflow is -

• Make changes in code and stage them.
• Create a commit
• Now a precommit script runs which formats the code.
• Then that unformatted code gets committed.
• The formatted code has to be staged and committed again
• Precommit script runs again, no changes in code occurs.
• The formatted files then gets committed.
• Now we can push the commits.

HMR i.e. Hot Module Replacement allows to only change one module which has changed without complete browser reload. Thus if state of one module is not changes if source code of another module changes.