Code Monkey home page Code Monkey logo

Comments (7)

youkha avatar youkha commented on July 20, 2024

from icn3d.

jiywang3 avatar jiywang3 commented on July 20, 2024

Yes, this is a good case to use Preferences. The membrane will be shown by default since it carries important information for biologists. Users could change the Preferences to hide it by default.

from icn3d.

digitalbio avatar digitalbio commented on July 20, 2024

I disagree. Here's why I think the red and blue discs should be hidden by default:

  1. The structure I reported, LQQ, is not a membrane protein.

  2. It's easy to find structures like 5VBL that are membrane proteins where the weird discs do not appear on loading. And the Toggle Membrane feature is not available.

  3. We did not have to work hard to find these two examples.

  4. The NCBI records in the MMDB do not show these discs. I think it makes more sense to click an image at the NCBI and see the same image appear in iCn3D.

  5. It is confusing to users to have these discs appear in structures, seemingly at random. I think you should look at the image in GitHub before drawing conclusions.

I am happy discuss this.

from icn3d.

jiywang3 avatar jiywang3 commented on July 20, 2024

I implemented "Show Membrane" in the menu "Style > Preferences". By default the membrane will be shown if it's available. Users could modify the Preferences as they like.

from icn3d.

digitalbio avatar digitalbio commented on July 20, 2024

This should really be the other way around with membrane objects hidden by default.

Our students don't know what these disc-like objects are. We didn't know what they were until Aron told us.

We should not be introducing new objects into structures unless the users want to see them.

I think this is something that should be turned on in Preferences and not on by default.

from icn3d.

youkha avatar youkha commented on July 20, 2024

from icn3d.

jiywang3 avatar jiywang3 commented on July 20, 2024

I fixed the membrane data of 5VBL. Now it's showing up: https://www.ncbi.nlm.nih.gov/Structure/icn3d/full.html?mmdbid=5VBL

from icn3d.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.