ncats / gsrs-play Goto Github PK

Errors when using the CDK-molwitch on the not most-abundant isotope due to the issue described in ncats/molwitch-cdk#7

If you create a new protein or edit an existing protein AND the protein has a structural modification of type AMINO ACID SUBSTITUTION, and extent is COMPLETE AND the molecular fragment references a substance whose molecular weight is in a property (a polymer, for example) AND molecular weight property has an average value but not a high and a low and a high limit and a low limit value, you get an error that prevents the registration from proceeding.
Work-arounds:

1. change extent to something other than COMPLETE (for example, use a specific value that is '100%')
2. add high AND low AND high limit AND a low limit to the MW property.
3. have the local administrator turn off protein validation (in the ginas.conf file).

The team is working on this issue for the next major release.

The SubstanceClass always has "reference" as the value for substanceClass. This field is annotated with JSONConstants.ENUM_REFERENCE in the file ix/ginas/models/v1/SubstanceReference.java. This looks wrong.

The Jurisdiction field available for editing for all Name types, but can be viewed (Details -> View) only for Official Names.

List View doesn't use a new Comparator Interface for codeSystem order calculation. It seems like client-side codes sorting (codeSystemOrder property in assets/data/config.json) will be used instead.

Proposal:
Codes within JSON already sorted by a new comparator. Client-side sorting can be skipped.

In a new 'Beta UI' Classifications will be displayed as Identifiers too.

Expected:
Classifications - contains only codes where isClassification() == true
Identifiers - contains only codes where isClassification() == false

Tracking issue for:

• https://github.com/ncats/gsrs-play/security/code-scanning/307

Only first Impurity will be displayed. Under Details -> Show button will be displayed number of impurities (o.e '(18 records)'). by pressing Show button will be displayed list of 'Mediator Substance' with 18 'none' entries.

The problem is related to this commit: https://github.com/ncats/gsrs-play/commit/22ca4c9f7f4d99a7206f79c1c3b32d7044ff0524#diff-a5a6b11b481b5ca4b8ffdd0a5c0ebda356eee1fccf35643f525afc41dac0f86e

The SCRIPT element was added to modules/ginas/app/ix/ginas/views/details/properties/relationships.scala.html.

After removing the SCRIPT element from relationships.scala.html Impurities will be displayed as expected.