nathanrsmith / http-rendezvous Goto Github PK

The regex's used to match routes are stricter than necessary, sometimes causing unexpected behavior for clients. For example, one of our http clients sends an auth-related argument in the query string of every request it makes because it's needed 90% of the time, and unknown query string arguments are normally ignored by routers.

How to Reproduce:
Send a valid request to any route with any query string at the end of the URL.

What Happens:
The server returns BadRouteError: No endpoint exists for the specified method and/or route.

What's Expected:
The request executes as normal, ignoring the query string.

It would be helpful to people on the download side of things to have some additional headers like content type and disposition (for default file name). This will significantly improve how browsers and other tools handle the download stream.

Currently, everything sent in the body of the PUT request is piped over to the GET side, but it would be helpful, for uploading from a webapp, if we could send files as form-data.

For example, a PUT request body like this:

------WebKitFormBoundarynZ754E75uK8wQZf9
Content-Disposition: form-data; name="file"; filename="testfile.psv"
Content-Type: application/octet-stream

1|2|3|4|5|data

------WebKitFormBoundarynZ754E75uK8wQZf9--

would result in the following coming out on the GET side:

1|2|3|4|5|data