Code Monkey home page Code Monkey logo

konpeito's People

Contributors

natade-jp avatar

Watchers

 avatar

konpeito's Issues

BigInteger.gcd() returns the incorrect value

BigInteger.gcd() function returns the incorrect value in specific arguments.
For example, I expect konpeito.BigInteger.create(33919).gcd(1500) to return 1, but actually 9.

Also, konpeito.Fraction makes unexpected numerator and denominator by normalization with incorrect gcd value.
https://github.com/natade-jp/konpeito/blob/v6.0.0/src/math/core/Fraction.js#L278

I think there is a problem with limiting the number of loops in gcd function.
https://github.com/natade-jp/konpeito/blob/v6.0.0/src/math/core/BigInteger.js#L1913

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.