nasa / tvsio Goto Github PK

Trick Variable Server Input Output is a Core Flight Software app that can transfer data to and from Trick simulations

License: Other

CMake 0.88% Makefile 1.59% C 93.39% Shell 0.01% Python 4.13%

tvsio cfs sbn trick

tvsio's Introduction

TVS-IO is a Core Flight Software (cFS) app that enables two-way communication between cFS's Software Bus Network (SBN) and Trick simulations.

Visit the TVS-IO App Wiki for information on how TVS-IO works, cloning, configuring, building, and running.

For a sample of how TVS-IO can be incorporated into a cFS project, see tvsio-demo

This app can be configured as any other CFS app would in a mission. The *.tvm files should be placed in the 'fsw/tvm_files/' directory and all CFS data types w/ an associated mapping in a *.tvm file must have their type definition in a header file in the 'fsw/types_inc' directory. However, it's a common-place for a mission to have a single 'include' directory somewhere that contains header files with all of the message definitions shared by CFS apps for that mission. In this case, you can simply replace the 'fsw/types_inc' with a symbolic link to said directory and all should be well.

TVS-IO is released under the NASA Open Source Agreement Version 1.3 license.

tvsio's People

Contributors

Stargazers

Watchers

Forkers

ralphhightower

tvsio's Issues

Specify rate of data from sim

The desired rate of messages from sim can be specified using the var_cycle command.

Per Thad: "I suspect that having sims with different rates may break the current architecture because of how we're looping."

Make TVMC cause all compiling to halt if there is a problem with generating code

A user noted that they had a significant problem with getting communications to work. The cause ended up being due to failure to fully parse a TVM file because of broken JSON formatting. The error/warning messages from TVMC were buried by the sheer volume of output from other compilation.

If TVMC can cause compilation to break, then this scenario will prevented in the future.

Updates to support cFE Draco RC4

Manually merging desired changes from draco-rc4+dev246 since it contains some good and some not so good code changes

Determine if mybogusfile.h in CMakeLists.txt is really necessary

the CMakeLists.txt file has the following comment:

# had to add "mybogusfile.h" which is never generated so the custom target above would always force this command to run

I suspect this isn't really necessary and can be avoided by tweaking the custom command and target.

Socket file descriptor leak

A new socket is opened every time ConnectToTrickVariableServer is called.

If connect fails in that function, the socket remains open and a new one will be created on the next call.

Make TVMC resilient to minor misspellings

TVM files are created and edited manually. So it would be good to make TVMC able to handle some basic typos

see branch feature/parse-enhance

Prevent TVMC from including duplicate headers in generated code

The TVMC code generator is naive about listing includes. So if the same header is used for multiple mappings it will insert the same include multiple times. Add some sanitizing to prevent this.

Reduce default TVS_IO_TRICK_PIPE_DEPTH

For some reason, TVS_IO_TRICK_PIPE_DEPTH defaults to 256.

This vastly larger than the other default depths.

It has required raising the system maximum queue depth in the past.

If there is some good reason it needs to be this deep, it should be documented.

Otherwise, it should be reduced.

Generated code created in src directory

Currently, tcs_io_generated.{c,h} are created in the fsw/src directory.

This is a problem when multiple cFS CPU instances use different .tvm files.

TVSIO_app multi sim support

Need to be able to support multiple trick sim connections, most of the development is planned to take place in the tvsio_cfs super project, pushing to this branch in the tvsio submodule

Feature/byte swap telemetry from trick

Requested for supporting systems which have different endianness than the sim host

Revisit unit tests

Revisit and update unit tests

Listen for TVS announce messages

Trick sends multicast messages announcing the running sim: https://nasa.github.io/trick/documentation/simulation_capabilities/Variable-Server#variable-server-broadcast-channel

These can be used for smarter reconnection behavior, and they could also be used to avoid needing hard-coded hostnames and/or ports.

I have a working implementation that uses them for reconnection.

Update/Improve child tasking

The child task ReceiveTaskRun() should be calling CFE_Status_t CFE_ES_RegisterChildTask(void) at startup and void CFE_ES_ExitChildTask(void) at termination.

Once registered, this should allow removal of "TVS_IO" from the prints in the child task

Improve handling of missing variables

The current behavior is typically a segfault :face_palm:

There are two things we can do better:

Detect the missing variable response when unpacking messages from sim: "The message returned for the non-existent variable will have a type of 24 and it's value will be the string 'BAD_REF'."
Ask Trick if variables exist using the var_exists command

I think we'll want to do both, since the latter will be the only way to check if variables used in commands exist.

When a variable is missing, the easiest response is to exit the app.

However we could do better and just turn off individual messages.