narukoshin / opensource-filemanager Goto Github PK

Formatting a date like this looks a little bit boring.

If the file is created today, then the date value will be Today, but if yesterday, then Yesterday.
And only if the file will be more than 2 days old, it will show the actual date.

When the server is working without restarts, at the start of a new day, there's no new log file created and logs are still going to a previous log file.

There should be a README file that will contain some information about the project, simple documentation, etc.

Sometimes there are files that are not meant for everyone to see.
A good feature would be to create password-protected folders and the files should be encrypted.

After some updates, the download function stopped working with the error that Content-Length is more than the actual data.

[martini] 2023/02/09 09:00:46 PANIC: http: wrote more than the declared Content-Length

Let's investigate, where the bug is hiding.

After implementing the #3 feature, a new bug appeared.

panic: open app/logs/logs_2023_02_08.log: too many open files

This error message says that it tries to open many files with the same name.

go func(){
    for {
	time.Sleep(time.Until(time.Now().Truncate(24 * time.Hour)))
	// It will create a new file every day
	file_name := fmt.Sprintf("logs_%s.log", time.Now().Format("2006_01_02"))
	f, err = os.OpenFile(filepath.Join(config.LogsFolder, file_name), os.O_WRONLY|os.O_CREATE|os.O_APPEND, 0644)
	if err != nil {
		panic(err)
	}
...

Error message appears because file opening happens in the for loop

Create a multi-functional API for creating/deleting files and folders and easier managing files.

End-point to create a new folder should be like this:

> request
POST /api/v1/folder

> data
{ "folder_name": "name" }

To delete the folder:

> request
DELETE /api/v1/folder

> data
{ "folder_name": "name" }

While file uploading the main problem is that the file that is uploading at the moment is visible and is not finished uploading.
Everyone can start downloading the uncompleted file, to avoid that, I need to write the file to a hidden temp file before and when the upload is completely finished, make it visible.