Error when downloading posts with "|" in the title about pixivutil2 HOT 4 OPEN

In config.ini for [Filename] I use customBadChars = "$'*:<>?\|, doing this allows the same sanitation without modifying the source.

This has always bugged me that we can't just set some sort of Windows or NTFS format flag in config.ini.

from pixivutil2.

@biggestsonicfan Thanks for the reply, I somehow missed this setting in config.ini

from pixivutil2.

My apologies, there is already a sanitization of filenames.

Within PixivHelper.py, the definition of forbidden characters is as follows:

__badchars__ = None
if platform.system() == 'Windows':
    __badchars__ = re.compile(r'''
    ^$
    |\?
    |:
    |<
    |>
    |\|
    |\*
    |\"
    ''', re.VERBOSE)
else:
    __badchars__ = re.compile(r'''
    ^$
    ''', re.VERBOSE)

Rewriting it to the following apparently fixed the issue but it is admiteddly a very rough impromptu fix:

__badchars__ = re.compile(r'''
    ^$
    |\?
    |:
    |<
    |>
    |\|
    |\*
    |\"
    ''', re.VERBOSE)

from pixivutil2.

More information, in case anyone wants to look into this:

Doing some more testing, it seems like the issue was not with Linux itself, but a combination of Linux and writing to an exFAT drive.

The main problem here might be the assumption that since an OS supports a charset, every filesystem it manages can handle it.

This might be a pretty fringe case, so might not be worth the effort to fix it.

from pixivutil2.