naimetti / rfc3339-validator Goto Github PK

Do you mind to drop python 2 support, e. g. remove six dependency?

Looms like latest pytest shows some warnings:

+ PYTHONPATH=/home/tkloczko/rpmbuild/BUILDROOT/python-rfc3339_validator-0.1.4-2.fc35.x86_64/usr/lib64/python3.8/site-packages:/home/tkloczko/rpmbuild/BUILDROOT/python-rfc3339_validator-0.1.4-2.fc35.x86_64/usr/lib/python3.8/site-packages
+ /usr/bin/pytest -ra
=========================================================================== test session starts ============================================================================
platform linux -- Python 3.8.12, pytest-6.2.5, py-1.11.0, pluggy-1.0.0
rootdir: /home/tkloczko/rpmbuild/BUILD/rfc3339-validator-0.1.4, configfile: setup.cfg
plugins: cov-3.0.0, hypothesis-6.36.0
collected 3 items

tests/test_rfc3339_validator.py ...                                                                                                                                  [100%]

============================================================================= warnings summary =============================================================================
../../../../../usr/lib/python3.8/site-packages/_pytest/config/__init__.py:1233
  /usr/lib/python3.8/site-packages/_pytest/config/__init__.py:1233: PytestConfigWarning: Unknown config option: collect_ignore

    self._warn_or_fail_if_strict(f"Unknown config option: {key}\n")

-- Docs: https://docs.pytest.org/en/stable/warnings.html
====================================================================== 3 passed, 1 warning in 10.31s =======================================================================

Hi,

I am using this library indirectly through another one.

I was noticing that the time-offset indicator whetzer it is Z or an actual offset is mandatory. However at least in ISO 8601 this is optional. Is there any way there can be a parameter where the time-offset validation can be optional?

• rfc3339-validator version: 0.1.4
• Python version: any
• Operating System: any

Description

The pytest-runner package is deprecated upstream. Its README now advises:

pytest-runner depends on deprecated features of setuptools and relies on features that break security mechanisms in pip. For example ‘setup_requires’ and ‘tests_require’ bypass pip --require-hashes. See also pypa/setuptools#1684.

It is recommended that you:

• Remove 'pytest-runner' from your setup_requires, preferably removing the setup_requires option.
• Remove 'pytest' and any other testing requirements from tests_require, preferably removing the tests_requires option.
• Select a tool to bootstrap and then run tests such as tox.

This came up in a review of a proposed python-rfc3339-validator package for Fedora Linux.

What I Did

• Followed pytest-runner upstream’s advice (leaving the already-empty setup_requires for now).
• Verified I can still run the tests with tox.

I also tried to run the tests with pip install -r requirements_dev.txt followed by python -m pytest or pytest, but this didn’t work on Python 3.10 because of the old pinned versions in requirements_dev.txt. However, after pip install --upgrade pip tox coverage pytest hypothesis strict_rfc3339, I was able to run the tests this way too.

I will offer these suggested changes as a PR.