nagyrobi / home-assistant-custom-components-pfsense-gateways Goto Github PK

The current version works only with http on default 80 port.
Sensor.py contains the following url format:
DEFAULT_RESOURCE = "http://{0}/status_gateways_json.php?key={1}"

Ii would be nice if protocol and port can be configured from HA sensor yaml, like:

sensor:
- platform: pfsense_gateways
  host: 192.168.1.1
  port: 9500
  ssl: true
  name: pfSense gateway
  key: pfsense
  monitored_gateway_interfaces:
    - wan
    - opt2

New requirements for custom components.

2021-03-01 12:28:49 WARNING (MainThread) [homeassistant.loader] No 'version' key in the manifest file for custom integration 'pfsense_gateways'. This will not be allowed in a future version of Home Assistant. Please report this to the maintainer of 'pfsense_gateways'

Can you clarify how you would configure this? I am having an issue even after modifying the sensor.py

Hi, my pfSense is on https. If i use http://pfSenseIP/status_gateways_json.php?key=pfsense I get routed to https but displayed with 503 error. if I use https://pfSenseHOSTNAME/status_gateways_json.php?key=pfsense I get json output in the browser but not in HomeAssistant

I had trouble getting the linecharts to appear properly on the sensor cards for ping and loss. After looking at it and thinking on it for a while, I realized the issue is that we're getting units (mS, %) in the value returned in the JSON, and thus into Home Assistant. They're actually displaying as (for example) "9.857mS mS".

By putting a floatval() around both ping and loss values in the pfSense-side .php, I now get numbers coming across rather than the strings, and the pretty lines draw across the bottom of my sensor cards.

The appropriate place to fix this is likely on the Home Assistant side. I'd make a similar change in the component, but I'm not familiar enough myself with Home Assistant development to validate the change. If I did, this would be a PR, not an issue.