n7st / metal.pl Goto Github PK

From t/30-schema/Channel.t:

my $module = 'Metal::Schema';

use_ok($module);

# TODO - for the next database test, move this to a module usable by other
# scripts
$module->connection('dbi:SQLite:dbname=:memory:', '', '') 
    || BAIL_OUT("Failed to create a test database schema in memory");
$module->load_namespaces();
$module->deploy();

This should be moved to a module so it can be included in other tests.

Travis appears not to be able to find Dist::Zilla or cpanm.

travis_time:end:0b03ed94:start=1491841818680395789,finish=1491843242793399959,duration=1424113004170
�[0K
�[31;1mThe command "dzil listdeps   --author --missing | grep -vP '[^\w:]' | cpanm --verbose" failed and exited with 1 during .�[0m

Your build has been stopped.

https://github.com/n7st/Metal/blob/master/lib/Metal/Module/Releases.pm#L30

share/migrations/_common/upgrade/1-2/001-insert_default_roles.pl should be moved to run on database install

• Move from a YAML-based config file containing API keys etc to using a database table for everything except the database connection information.
• Wizard to get "initial" config values such as nick, server, etc...
• Config settable by users with available permission through IRC.

Related to https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=882618

Module for individual channels to follow tweets from specific accounts.

Currently littering the base class in lazily built Moose attributes.

• Implement DBIx::Class::Migration (tutorial)
• Reconsider subclassing for modification dates and rows belonging to users (these columns are common to almost all tables)

The included datetime parser appears not to take into account hours/minutes/seconds.

sub user_stat_today {
    my $self    = shift;
    my $handle  = shift;
    my $user_id = shift;

    my $dtf       = $self->result_source->schema->storage->datetime_parser;
    my $yesterday = DateTime->now->subtract(days => 1);
    my $stats     = $self->search_rs({ name => $handle })->first;

    return 0 unless $stats;

    my $for_user = $stats->user_stats;

    return $for_user->search_rs({
        user_id      => $user_id,
        date_created => { '>=' => $dtf->format_datetime($yesterday) }, 
    })->count();
}

This role would make more sense with separate methods for finding a user from the current user's hostmask and finding one from a provided name if given and falling through to the current user otherwise.

http://search.cpan.org/~bingos/POE-Component-IRC-6.88/lib/POE/Component/IRC/State.pm