n-ham / lolcat-cc Goto Github PK

Hello!

Its been a long time since my first post about "Options Clarification". I've been running this application since then and it is very good and fast, does what I want.

However I had to reinstall my Linux machine, so I went to this site to get the program and I saw there is a new version.

When compiling (that is 'make' it), I get this warnings:

`~ $ make

g++ -std=c++11 -Wall -Wextra -pedantic -O3 -o lolcat-cc lolcat-cc.cc
lolcat-cc.cc: In function ‘int lolcat(std::istream&)’:
lolcat-cc.cc:219:44: warning: comparison is always true due to limited range of data type [-Wtype-limits]
219 | inLine[i] != -80 &&
lolcat-cc.cc:220:44: warning: comparison is always true due to limited range of data type [-Wtype-limits]
220 | inLine[i] != -92 &&`

1. The program is indeed built, but this warnings seems to me very odd (comparison always true...) for me to rest about them.

2. I'm compiling it on an arm CPU, raspbian / Raspberry OS, 32 bits system.

3. This issue does not happen with previous version (as far as I remember and tested).

Just to let you know about this, maybe you can give it a little more of a thought on this issue in order to fix it. I could do it myself but it is for me.. kind of hard follow you train of thought on this program, mainly because C++ is not my wave.. YET!!! :-D

Thank you very much indeed.
lramalho

The degree symbol, sometimes works, sometimes display other symbol character before the "°".

When it doesn't shows correctly, appears like:
cpu temp 31°

When it does works fine display:
cpu temp 31°

Please could you check the degree symbol if can be fixed constantly? Thank you!

Tested on
lolcat-cc used as a binary from tags
Devuan/Testing 5 // Debian/Testing 12
rxvt-unicode 9.30-2+b1
bash 5.1-5+b1

This is not an issue, but...

I can't find any explanation about the options, as they are different from the one in the original lolcat(rb) and lolcat-c.

In my debian, I did "apt list --installed > pack.txt", so I have a long text file to test
Using "cat pack.txt | lolcat-cc ..." with the various options, I couldn't understand part of them.

1. I can't understand what the option "-f: format" do. Sometimes it do zig zag pattern others it does sloping pattern.

2. I'm Assuming "-zz" is a zigzag pattern, is it correct?

3. The option "-g=[d]" seems to change the slop angle of the color strips, but this option seems to be ignored when used in conjunction with option -zz. Besides, calling "-g=[d]" gradient, seems incorrect, as if not describe exactly what the option really do. However, if we look to this option as the speed at which color change (lets call it gradient indeed), I guess the final result, from the perspective of multiple lines, seems like a change in the sloping.

4. Printing a long file, even not applying option "-zz" it seems that the +/- (zig zag) pattern is triggered some times.
   Other times sloping seems negative other times sloping seems positive, I can't find a way to control this, there is no consistent presentation.

5. Option "-ps" seems does nothing, at least in linux.

6. I can't spot any difference in using or not option "-tw=[i]".

7. I can't spot any difference in using or not option "-w=[i]".

For short, seems there is no consistent pattern presentation, even when not using any option!

I hope I you did understand me.

Sorry my lousy English.

As we can see from the photo, there is a large part not completely covered.
neofetch | lolcat -f

When I

neofetch | lolcat

This is what I get,

Is there a fix to this?