myrjola / diminish.el Goto Github PK

Hello!

With latest commit 8bed521

1. emacs -Q
2. Eval (package-initialize)
3. Eval (diminish 'eldoc-mode)

Debugger entered--Lisp error: (void-variable copy-alist)
  byte-code("\10\204\11\0\303\11\n\"\210\303\207" [diminish-must-not-copy-minor-mode-alist copy-alist minor-mode-alist callf] 3)
  (diminish 'eldoc-mode)
  eval((diminish 'eldoc-mode) t)
  eval-expression((diminish 'eldoc-mode) nil nil 127)
  funcall-interactively(eval-expression (diminish 'eldoc-mode) nil nil 127)
  call-interactively(eval-expression nil nil)
  command-execute(eval-expression)

Emacs 27.0.1

Thanks for sharing this package! I use the https://github.com/Malabarba/emacs-google-this
The strange thingy is that Dminish works well for all modes, but I never managed to hide Google-this-mode in the statusbar.

Examples:

(with-eval-after-load 'google-this-mode
(google-this-mode . ""))


(diminish 'google-this-mode)


(with-eval-after-load 'google-this-mode
    (diminish 'google-this-mode))

The Google mode is still popping up in my mode line. Another suggestion?

I have tried:

(apheleia-global-mode +1)
(diminish 'apheleia-mode)
(diminish 'apheleia-global-mode)

But I keep seeing Apheleia at the bottom line.

Driver.py ~/program/user Git:dev (home) [Py] Top (15, 0) Apheleia------------

Would it be possible to suppress it?

Hey!

Running M-x diminished-modes returns the following error:

setq: Wrong type argument: characterp, " "

I am using company-mode and if I display messages before trying to apply mapconcat on it, I get:

(" ElDoc" "" " PgLn" "" " WK" " Projectile[.emacs.d:generic]" "" nil (" " (company-candidates (:eval ...) company-lighter-base)) " hl-p" " ws")

I'd love to diminish all minor modes except for a few like projectile and lsp-mode. Is there a way to do so? It would save the user so many lines of "diminish" keywords.

Hi!

Looking closer at the copyright status of this package, I noticed that the copyright header says ";; Copyright (C) 1998 Free Software Foundation, Inc.". Do you know if that means that Will Mengarini has assigned copyright to the FSF?

If that is true, and he is the sole author of this code before it entered git, we only have two significant contributors. This would mean that we could add it to GNU ELPA, if you agreed to also assign copyright to the FSF (if you haven't already).

If that is not true, we could still add it to GNU ELPA, but we would need copyright assignments from both of you.

Adding it to GNU ELPA would be useful, as it opens the possibility for shipping diminish.el with Emacs itself in the future.

What do you think?

Hello

I will use some lazy loading:

(add-hook 'after-init-hook 'which-key-mode)

In this case do I need to put diminish in with-eval-after-load?
e.g.:

(with-eval-after-load 'which-key
  (diminish 'which-key-mode))

Thank you.

I'm trying to diminish the holy-mode (from Spacemacs) and smartparens-mode but it doesn't work. However, other modes I tried to diminish so far working perfectly like merlin, projectile.

Do you know what happens with the holy-mode and smartparens-mode?

Below is the code that I use:

  ;; smartparens
  (eval-after-load "smartparens-mode" '(diminish 'smartparens-mode " ⒫"))

  ;; holy-mode
  (eval-after-load "holy-mode" '(diminish 'holy-mode " ⓗ"))
  (with-eval-after-load 'holy-mode '(diminish 'holy-mode " ⓗ"))

Thanks for taking your time to look at my issue! :-)