Code Monkey home page Code Monkey logo

fancybox's People

Contributors

eldenroot avatar lairdshaw avatar svepu avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

fancybox's Issues

Deactivation Error

when I deactivate the plugin, it will be shown in the plugin list to "install and activate". Also the entry for settings is shown ...
After reinstall I have the settings two times in my forum (1.8.24, php 7.3.x), one time the setting for per-post-gallery is not shown (is in the remained settings entry after deactivate)

Warning - this_script

"Warning [2] Use of undefined constant THIS_SCRIPT - assumed 'THIS_SCRIPT' (this will throw an Error in a future version of PHP) - Line: 383 - File: inc/plugins/mybbfancybox.php PHP 7.4.16 (Linux)"

Update JS library to 3.4.1

FancyBox v3.4.1 was released as a bug fix and a new features release. I will update it in this plugin before releasing v0.6. I think there will be more changes in this library due to many new additions which could bring new bugs.

Ipad issue

On iPad, zoomed image remains static even clicking outside the image. I have to click 'x' to close zoom. - This is an issue.
On PC and Mobile, clicking outside of the zoomed image is closing zoom. - This is perfectly working.

Thumbnail Template Customizations Lost At Install

Because of the way postbit_attachments_thumbnails_thumbnail is overwritten and replaced, if admin tries the plugin and decides not to use it, they will have lost all customization to that template.

Add watermark support

I have a working code for watermark support, I would like to add when others things will be added.

download button not work

thank you very much for this awesome plugin.
after test i see that download button not start downloading the image , only the image link is shown in address panel of browser.

thank you.

can't deactivate the plugin

hello; when i decativate/uninstall the plugin i have success message on acp; but the plugin still working.

Previous&Next / Slideshow

hello;
i m asking if there is a possibility to add or activate slideshow option and navigation option (previous/next) because its very useful when wa have many pictures in a post..

thanks.

Should there be a single gallery for all images on the page?

My suggestion: yes, there should be only one image gallery per page.

Currently there are separate galleries, generally (always?) one for each post on the page.

It seems that converting all of these separate galleries into a single gallery would be as simple as setting the data-fancybox attribute to a single, constant value everywhere it is used (untested, but based on the FancyBox documentation).

Attachment images disappear on pop-up for "Full Size Image" ACP option

When in the ACP, Home » Board Settings » Attachments » Show Attached Thumbnails in Posts is set to "Full Size Image", attached files which have not been inserted into the post (and which therefore show up full-size under "Attached Files" at the bottom of the post) disappear from that location as soon as they are clicked on so as to activate the FancyBox pop-up (they show fine in the pop-up though).

It seems that this happens because, for some strange reason, FancyBox behaves in this way when the a tag enclosing the image does not have its href attribute set (which I twigged on to when I read this comment in the fancyBox GitHub repository), and line 395 of inc/plugins/mybbfancybox.php fails to set the href attribute of the a tag which it creates.

Plugin Abandoned ?

Looks like this great plugin has been abandoned which is a shame. Does anyone know how I can change the error message when a user can't access an attachment?

FancyBox on portal and announcements

I know you already have stated that you won't support fancybox on portal.php, but still I don't know why. It would be awesome to have it working there. Is it hard to do, or you just don't want to do it, because you don't use that feature of MyBB?

Also if you open announcement it also has no FancyBox support. It would be nice to have it also there ;)

I like this plugin, it makes going through images much easier and better. Since I want to use portal on my forum based on MyBB I just want to be sure if it isn't going to be supported.
Please if you can consider supporting portal.
If you really don''t want to or simply can't then I will most likely try to add support myself. 🍰

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.