Comments (4)
patrickdowling
commented on May 25, 2024
1
The incomplete state kind of irks me as well (even if it's not really my circus).
My personal preference would be that Shay have his own fork(s), put the releases and track his hardware changes there, so it also becomes the default port of call for support issues. The various #defines have gotten a bit out of hand.
To be fair, Shay and I were in touch a while back, but all other issues aside, to fix things the way I'd like them done requires more time investment than I've wanted to divert from other things.
from o_c.
Chysn
commented on May 25, 2024
@Chysn <https://github.com/Chysn> (tagging you because of #90
<#90> - thanks for that! ), is there a
hardware limitation preventing the chosen VOR option to be saved to EEPROM?
That would be a shame. Or do the aforementioned save methods (and/or all of
the apps' own save functions; for example,
https://github.com/mxmxmx/O_C/blob/master/software/o_c_REV/APP_ENVGEN.ino#L852-L857 )
still need to be updated? Or maybe SettingsBase.Save in util_settings?
No hardware limitation, but it's a matter of allocating very limited space.
I can't say whether such opportunities still exist in the Ornament and
Crime firmware.
…--Jason
On Wed, Dec 9, 2020 at 10:00 PM W. Winter ***@***.***> wrote:
The VOR option chosen through VBiasManager is not saved by
save_global_settings() or save_app_data(). It must always be re-selected
every time the module is powered up. Apologies if discussing VOR in an
issue here is considered outside the scope of the main O_C repo.
@Chysn <https://github.com/Chysn> (tagging you because of #90
<#90> - thanks for that! ), is there a
hardware limitation preventing the chosen VOR option to be saved to EEPROM?
That would be a shame. Or do the aforementioned save methods (and/or all of
the apps' own save functions; for example,
https://github.com/mxmxmx/O_C/blob/master/software/o_c_REV/APP_ENVGEN.ino#L852-L857
) still need to be updated? Or maybe SettingsBase.Save in util_settings?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#108>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AENMQVHP3VEE4ZG3MWSO2N3SUA2URANCNFSM4UUMITVQ>
.
from o_c.
patrickdowling
commented on May 25, 2024
Yeah, space is a bit tight but I think it'd fit somewhere. Shay mentioned wanting it to be saved per app which is a bit more involved (it'd either have to be in all the _save/_loads, or added as a (hidden?) entry in the settings arrays). The one issue is that it will likely break existing settings data, and possibly calibration.
Right now the VOR stuff is in a bit of limbo. I don't really think it should live in this repo - or rather, I don't think we should be fielding support for it - but AFAIK there's no other plan. There's a few other unsolved issues as well.
from o_c.
w-winter
commented on May 25, 2024
Thanks for clarifying @patrickdowling and @Chysn . I understand that there are a couple of other issues besides storing the VOR settings: VOR breaking autotune, and a ~3mV offset between the calibration interface and normal operation of the DAC.
The VOR storage part irks me and I'd like to find someone to help with these issues. I also understand that you'd prefer for further development of the VOR features to not live within the O_C repo. Would it work if Shay forked this repo and further VOR work happened there, or would a more radical break than forking be preferable?
from o_c.
Related Issues (20)
- Acis Curds - changing root note has no effect
- Autoune tune not behaving correctly HOT 10
- My O&C won't start after trying to update firmware HOT 4
- 10mv offset on all OCP outputs HOT 18
- Optimization question HOT 2
- Bug with Piqued's "Gate High" parameter
- Unable to long press during CV Input Scaling calibration HOT 2
- Feature request: attenuator and offset as an extra parameter to apps doing sampling HOT 2
- "ShiftReg" on right hemisphere wont change loop length. Stuck on "2" steps. HOT 2
- Teensy 4.0 challenges - I am not asking you to do this work HOT 8
- Quad quantizer transpose with aux CV HOT 3
- Request - CPL or Pick and Place file for the PCB HOT 3
- How to build on 64-bit machines HOT 2
- Change the name HOT 9
- Teensy: hex file too large HOT 2
- Possible to add a second channel shift register to Copier machine? HOT 1
- teensy 4 version HOT 1
- 1.3.6 firmware: HOT 10
- building o_c in catalina HOT 20
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from o_c.