The maxime-moreau.fr from mxmaxime

maxime-moreau.fr's Introduction

Hi there, I'm Maxime 👋 🇫🇷

I'm a Software Engineer at Fruitz 🍑, previously at OVHcloud & Airbus ✈️
⚡ I fall into the kettle of magic potion in 2012 by coding in C/PHP with some Arduino's and RaspberryPi's!
👷 Most used languages: Go, JavaScript, Python.
💻 Linux, vim lover.
🌾 Beside's programming, I love traveling, hiking, biking. Oh my dear country side.
🏡 Main project: Bobby home, your open source alarm to leave your home with a peace of mind.

maxime-moreau.fr's People

Watchers

maxime-moreau.fr's Issues

Configuration : bad design

Let the code explain itself:

<?php
// container.php
$container[Asset::class] = function (ContainerInterface $container) use($configRepository) {
  $appConfig = $configRepository->get('app');

  if (ASSETS_DELIVERED_WEBPACK) {
    return new \Emix\Asset\Asset(null, ASSETS_DELIVERED_WEBPACK_URI . '/' . getenv('ASSETS_PUBLIC_PATH'));
  }

  return new \Emix\Asset\Asset(ASSETS_FILEINFO_PATH);
};

I'm using some global constants. From where ? Hmm...
bootstrap.php -> assets.php:

<?php

define('ASSETS_DELIVERED_WEBPACK', filter_var($useWebpack, FILTER_VALIDATE_BOOLEAN));

// We use the "assets".json file to deliver the assets.
if (ASSETS_DELIVERED_WEBPACK === false) {
  $assetsFileinfo = getenv('ASSETS_FILEINFO');

  $file = root_path() . '/' . $assetsFileinfo;
  define('ASSETS_FILEINFO_PATH', $file);
  if (!file_exists($file)) {
    throw new Exception('something wrong');
  }
}

Bad!
I have to use something like my ConfigRepository.

Propals

ConfigRepository

I've an object ConfigRepository which takes my configuration from my .config.php files. And then, I have to check my config and sometimes populate new things.