mvandenbos / steuerbescheinigungen-spender Goto Github PK

In the Template, there is header called "Totalsumme" but in the PDF it is called "Gesamtsumme".

They should both read "Gesamtsumme"

In the template, under Report, please add the ability to have a title with multiple lines.

example:
Anlage zur Sammelzuwendungsbestätigung vom 10.01.2019
Aussteller: Christliche Gemeinde Heidelsheim e.V.

A married couple should only receive one document where all donations from each person are combined.
The recipient field should therefore also contain both names

This will allow users to easily backup their current template and upload to either a new install, different machine or a failed update.

Currently, all JSON files are saved locally within the application but on updates these are overwritten.

See #7

Update the template.json data to be saved locally so it persists after an update.

Currently the filename starts always with "fcg-spendenbescheinigung-".
This should be the church-name from the settings.

And the year of the XLSX-Filename is 2020, of the PDF-Filename 2019 (as configured in the template).

Currently the default ALT-Text is: "die ALT Text Beschreibung zu deine Logo"

Proper German is: "Die alternative Beschreibung für dein Logo"

Needs to be fixed in "settings/settings.json"

This will be used to save all user edited data locally and ensure that this data remains after an update to the application.

Right now, the excel structure requires a specific format, this needs to be updated and an interface added that will allow users to map their excel imports to the required fields in the application.

When copying another config.json file to %AppData%\Electron\config.json after launching the App, the old config.json gets restored.

Is that behaviour desired?

The localFileManager.js:readFromUserDataAndLocalStorage() is first reading from the localStorage and only if that is empty, then uses the electron-store which is saved to the config.json.

So currently there is no way to get a configuration (Settings & Template) to another computer except overwriting that method to first read the electron-store

Since a few versions ChurchTools by default requires a CSRF-Token to be sent with every API request:

https://intern.church.tools/?q=churchwiki#WikiView/filterWikicategory_id:0/doc:API-CSRF

This feature can be disabled but is not available in future versions

In the PDF-Document above the recipient address should be an extra line with a return address.
In case a letter is sent via Post and can't be delivered, it is returned to the sender.

Some churches require the Cashier to also sign the documents and it would be good to have an additional signature block

According to addisonparser.js the donations are sorted by a["Buchungsdatum"].toLowerCase().
But the date is in the format dd.mm.YYYY so it is sorted wrong.

Currently, all JSON files are saved locally within the application but on updates these are overwritten.

See #7

Update the setting.json data to be saved locally so it persists after an update.

It would be great to have the ability to use a %Date% macro in the template text entered by the user to allow for entering today's date.

The ability to add a Logo to the Header of the PDF-Document (variable position?) would be great.

Update the template to allow a return address to be added above the TO: address on the template. This will allow users to save the time of having to manually add this to the envelopes.

Add a check on the data parser between the Churchtools and the Excel import that will flag any records where the the Names are different but the "SharedID/SpenderID/OptigenNr" is the same.

Fix the sorting using in the arrays to ensure they sort using international phonebook standards:

example:
ä sorts with ae

This requires this type of localCompare parameter de-DE-u-co-phonebk

References
https://www.jstips.co/en/javascript/sorting-strings-with-accented-characters/

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl#locales_argument

If you press Enter after typing your password nothing happens.
You first have to TAB out or use the mouse to click on "ANMELDEN"

Add under the settings menu, the option to upload and use an image as a church logo in the app/nav header.

Add a check on the data parser between the Churchtools and the Excel import that will flag any records where there are duplicate Churchtools persons.

They may have the same UniqueID/SpenderID/OptigenNr so that is a point to check in the parse.

In the addisonparser.js;getDonorsFromAddisonExport() the Excel-File is mapped depending on fields/columns being undefined.

For the case of "Gegenkonto" the field is "Konto" is checked if undefined instead of "Gegenkonto", which can lead to an error.

Wrong Code: "Gegenkonto": (rec["Konto"] == undefined) ? rec["Kontonummer"] : rec["Gegenkonto"]
Right Code: "Gegenkonto": (rec["Gegenkonto"] == undefined) ? rec["Kontonummer"] : rec["Gegenkonto"]

The Template that is used for generating PDFs is always the default accoring to pdfreport.js:

const filePath = path.join(__dirname, "..", "/template/template.json");

function getTemplateData () {
  let rawdata = fs.readFileSync(filePath);  
  let data = JSON.parse(rawdata);  
  return data
}

This should probably be changed to use the localFileManager.js
localFileManager.get(localStore, keys.TEMPLATE)

If the provided Excel-File does not contain the Column "Buchungsdatum" the sorting fails, but no Error Message is shown:

The reason for that is, that in the catch block the Exception is not casted to a string.
Replacing deferred.reject({message: e}) with deferred.reject({message: String(e)}) fixes the problem:

After importing a TEMPLATE_EXPORT the LetterHead.subheaders are overwritten by the Letter.subheaders and other fields as well. It seems as if the Parent-Element is not considered at all.