mulesoft-labs / osprey-router Goto Github PK

We're trying to use the osprey-mock-service in a gated environment with no git access and our deploy is failing at connecting to github to fetch blakeembrey/router#router-engine

Is there a reason this is using a fork of https://github.com/pillarjs/router (which is in npm, and is one path release in front of the fork)?

This dependency blocks the ability to run in a CI/CD build, as a github style URLs attempt to git clone a dependency, instead of pulling from an NPM registry.

We have a closed environment that only has access to NPM packages through an Artifactory NPM registry.

The registry caches npmjs registry for anything not found in the private registry.
Any package can be published to the private registry.
Hitting URLs outside of the internal registry is not allowed.

(redacted, not specific to this repo)

🚨 Reminder! Less than one month left to migrate your repositories over to Snyk before Greenkeeper says goodbye on June 3rd! 💜 🚚💨 💚

Find out how to migrate to Snyk at greenkeeper.io

The dependency raml-path-match was updated from 2.3.0 to 2.3.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

raml-path-match is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

Hi, I've been looking at implementing part of the Facebook API which happens to have some of the same structure in terms of (base) resources as the one used in your example.

As a matter of fact: /{user_id} although here is used /{userId}, I would assume these are not considered equal forms of the same resource?

Also, in scope of using Osprey, I cannot use these kind of paths as they would simply resolve to a Cannot GET /v1/1234 (for example).

Any chance you could enlighten me on this, I would be grateful. Thing is, the example shown in README doesn't offer for much 'out-of-the-box' working hello world when there isn't a (api).raml file to go along with it. So either providing a inline version in README, or as a file, might be handy... either way, as it sits now, I can't get it to work/duplicate.

Every router should be able to inherit the schema from previous instances for routing params. This will be extremely useful when used with Osprey core to generate the parameter schemas from RAML. Subsequent routes would no longer need to have a schema defined when using this router. See mulesoft/osprey#74.

Edit 1: When a schema has already been defined for a parameter, we will compare the schema. If they differ, we should throw a runtime error on the server-side to fix the route.

Edit 2: This should be an option, enabled by default. Something like new Router({ mergeSchemas: false }).

Edit 3: It is valid to do this before a route execution. For example, when mounting we can check if it's an Osprey instance and pass the schemas through a property. However, this breaks down when using a combination of Express and Osprey routers, so need to decide which is the better trade-off.

The dependency array-flatten was updated from 2.1.1 to 2.1.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

array-flatten is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

The dependency raml-path-match was updated from 2.2.0 to 2.2.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

raml-path-match is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

Hello, would you be able to cut a new version of this lib and bump the dep in osprey itself? I need a release that has PR #2 in it :)

I was running [email protected] node_modules/osprey with "express": "^4.12.0" on the latest version of nodeJS (v0.12.0).

https://github.com/jewelsjacobs/raml-osprey-api-designer/blob/master/routes/documentation.js#L85

I think this might be caused by a bug in https://github.com/pillarjs/router which references a path that does not resolve to a file or module. I went ahead and logged an issue in that repo: pillarjs/router#16

module.js:338
    throw err;
          ^
Error: Cannot find module 'router/engine'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:278:25)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/jewelsjacobs/WebstormProjects/raml-api-designer/node_modules/osprey/node_modules/osprey-router/osprey-router.js:1:76)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)